Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove compatibility with non-hierarchical projects #254

Merged
merged 1 commit into from
Apr 7, 2023

Conversation

twyatt
Copy link
Member

@twyatt twyatt commented Apr 5, 2023

See michaelbull/kotlin-result#71 (comment) for more details on why we should only support hierarchical consumers.

@twyatt twyatt requested a review from a team as a code owner April 5, 2023 23:17
@twyatt twyatt added the maintenance General maintenance that doesn't effect the public API. label Apr 5, 2023
@github-actions
Copy link

github-actions bot commented Apr 5, 2023

Test Results

  32 files    32 suites   7s ⏱️
233 tests 226 ✔️   7 💤 0
250 runs  238 ✔️ 12 💤 0

Results for commit cdac600.

@codecov
Copy link

codecov bot commented Apr 5, 2023

Codecov Report

Merging #254 (cdac600) into main (1c1547e) will decrease coverage by 8.99%.
The diff coverage is 80.27%.

@@             Coverage Diff              @@
##               main     #254      +/-   ##
============================================
- Coverage     94.44%   85.46%   -8.99%     
- Complexity       51       91      +40     
============================================
  Files            13       20       +7     
  Lines           126      282     +156     
  Branches          8       15       +7     
============================================
+ Hits            119      241     +122     
- Misses            6       37      +31     
- Partials          1        4       +3     
Impacted Files Coverage Δ
coroutines/src/commonMain/kotlin/flow/Combine.kt 0.00% <ø> (ø)
logging/src/commonMain/kotlin/Metadata.kt 76.92% <0.00%> (-0.86%) ⬇️
logging/src/commonMain/kotlin/Sensitivity.kt 0.00% <0.00%> (ø)
...tines/src/commonMain/kotlin/delay/DelayStrategy.kt 47.50% <47.50%> (ø)
logging/src/commonMain/kotlin/DispatchLogger.kt 92.10% <89.65%> (-7.90%) ⬇️
logging/src/commonMain/kotlin/Log.kt 98.27% <93.75%> (-1.73%) ⬇️
logging/src/commonMain/kotlin/FilterLogger.kt 95.65% <95.65%> (ø)
...t/src/commonMain/kotlin/TuulboxKtorClientLogger.kt 100.00% <100.00%> (ø)
logging/src/commonMain/kotlin/FilterLevelLogger.kt 100.00% <100.00%> (ø)
logging/src/commonMain/kotlin/LogLevel.kt 100.00% <100.00%> (ø)
... and 1 more

... and 2 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@twyatt twyatt enabled auto-merge (squash) April 5, 2023 23:59
@twyatt twyatt merged commit 9f2ec7e into main Apr 7, 2023
@twyatt twyatt deleted the twyatt/enableCompatibilityMetadataVariant branch April 7, 2023 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance General maintenance that doesn't effect the public API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants