Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix determination of minimum log level for dispatch logger #264

Merged
merged 1 commit into from
Apr 28, 2023

Conversation

twyatt
Copy link
Member

@twyatt twyatt commented Apr 25, 2023

The minimum log level when multiple loggers were installed was incorrectly determined to be the max level of all loggers, when it should've been the minimum.

This bug would be witnessed if logger A (level Verbose) was installed with logger B (level Assert), whereas you'd only see assertion log messages (when you should've still seen all logs from logger A).

@twyatt twyatt added the patch Changes that should bump the PATCH version number label Apr 25, 2023
@github-actions
Copy link

Test Results

  32 files    32 suites   7s ⏱️
233 tests 226 ✔️   7 💤 0
250 runs  238 ✔️ 12 💤 0

Results for commit da4c6f4.

@codecov
Copy link

codecov bot commented Apr 25, 2023

Codecov Report

Merging #264 (da4c6f4) into main (1c1547e) will decrease coverage by 8.99%.
The diff coverage is 80.27%.

@@             Coverage Diff              @@
##               main     #264      +/-   ##
============================================
- Coverage     94.44%   85.46%   -8.99%     
- Complexity       51       91      +40     
============================================
  Files            13       20       +7     
  Lines           126      282     +156     
  Branches          8       15       +7     
============================================
+ Hits            119      241     +122     
- Misses            6       37      +31     
- Partials          1        4       +3     
Impacted Files Coverage Δ
coroutines/src/commonMain/kotlin/flow/Combine.kt 0.00% <ø> (ø)
logging/src/commonMain/kotlin/Metadata.kt 76.92% <0.00%> (-0.86%) ⬇️
logging/src/commonMain/kotlin/Sensitivity.kt 0.00% <0.00%> (ø)
...tines/src/commonMain/kotlin/delay/DelayStrategy.kt 47.50% <47.50%> (ø)
logging/src/commonMain/kotlin/DispatchLogger.kt 92.10% <89.65%> (-7.90%) ⬇️
logging/src/commonMain/kotlin/Log.kt 98.27% <93.75%> (-1.73%) ⬇️
logging/src/commonMain/kotlin/FilterLogger.kt 95.65% <95.65%> (ø)
...t/src/commonMain/kotlin/TuulboxKtorClientLogger.kt 100.00% <100.00%> (ø)
logging/src/commonMain/kotlin/FilterLevelLogger.kt 100.00% <100.00%> (ø)
logging/src/commonMain/kotlin/LogLevel.kt 100.00% <100.00%> (ø)
... and 1 more

... and 2 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@twyatt twyatt marked this pull request as ready for review April 26, 2023 00:02
@twyatt twyatt requested a review from a team as a code owner April 26, 2023 00:02
@twyatt twyatt enabled auto-merge (squash) April 26, 2023 04:10
@twyatt twyatt added this to the 6.4.1 milestone Apr 26, 2023
@twyatt twyatt merged commit f1d2a0d into main Apr 28, 2023
@twyatt twyatt deleted the twyatt/logger/logLevel branch April 28, 2023 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch Changes that should bump the PATCH version number
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants