Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify binary-compatibility-validator setup #353

Merged
merged 3 commits into from
Mar 13, 2024
Merged

Simplify binary-compatibility-validator setup #353

merged 3 commits into from
Mar 13, 2024

Conversation

twyatt
Copy link
Member

@twyatt twyatt commented Mar 9, 2024

Updates configuration to more closely match official setup instructions (by not configuring/using a shorthand name for the plugin — in other words: no longer using resolutionStrategy).

twyatt added 2 commits March 8, 2024 19:23
@twyatt
Update AtomicFU configuration
5818b2f 
Now pulling in AtomicFU via `classpath` in `buildscript.dependencies` as
it more closely aligns with official [setup instructions].

[setup instructions]: https://github.com/Kotlin/kotlinx-atomicfu?tab=readme-ov-file#apply-plugin
@twyatt
Simplify binary-compatibility-validator setup
25eb688
@twyatt twyatt added the maintenance General maintenance that doesn't effect the public API. label Mar 9, 2024
@twyatt twyatt requested a review from a team as a code owner March 9, 2024 09:31
@twyatt twyatt requested review from Phoenix7351 and QuantumRand and removed request for a team March 9, 2024 09:31
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 9, 2024 •
edited
Loading

Test Results

100 files  ±0  100 suites  ±0   5s ⏱️ -9s
845 tests ±0  836 ✅ ±0   9 💤 ±0  0 ❌ ±0 
862 runs  ±0  848 ✅ ±0  14 💤 ±0  0 ❌ ±0 

Results for commit c1ea55c. ± Comparison against base commit e810572.

This pull request removes 206 and adds 206 tests. Note that renamed tests count towards both. 
com.juul.tuulbox.collections.AtomicMapTests ‑ atomicMap_concurrentMutateBlocks_doesNotLoseWrites[js, browser, ChromeHeadless121.0.6167.139, MacOS10.15.7]
com.juul.tuulbox.collections.AtomicMapTests ‑ atomicMap_mutateAndSnapshot_returnsNewSnapshot[js, browser, ChromeHeadless121.0.6167.139, MacOS10.15.7]
com.juul.tuulbox.collections.AtomicMapTests ‑ atomicMap_snapshotAndMutate_returnsPreviousSnapshot[js, browser, ChromeHeadless121.0.6167.139, MacOS10.15.7]
com.juul.tuulbox.collections.PojoMapTest ‑ toJsObject_whenEmpty_isEmpty[js, browser, ChromeHeadless121.0.6167.139, MacOS10.15.7]
com.juul.tuulbox.collections.PojoMapTest ‑ toJsObject_withArrayValue_stringifiesToSimpleJson[js, browser, ChromeHeadless121.0.6167.139, MacOS10.15.7]
com.juul.tuulbox.collections.PojoMapTest ‑ toJsObject_withMultipleEntries_hasKeys[js, browser, ChromeHeadless121.0.6167.139, MacOS10.15.7]
com.juul.tuulbox.collections.PojoMapTest ‑ toJsObject_withMultipleEntries_hasValues[js, browser, ChromeHeadless121.0.6167.139, MacOS10.15.7]
com.juul.tuulbox.collections.PojoMapTest ‑ toJsObject_withNumberStringPair_stringifiesToSimpleJson[js, browser, ChromeHeadless121.0.6167.139, MacOS10.15.7]
com.juul.tuulbox.collections.PojoMapTest ‑ toJsObject_withStringNumberPair_stringifiesToSimpleJson[js, browser, ChromeHeadless121.0.6167.139, MacOS10.15.7]
com.juul.tuulbox.coroutines.delay.DelayStrategyTest ‑ calculatedDelayResultsInInfinity_returnsMaximumDelayMillis[js, browser, ChromeHeadless121.0.6167.139, MacOS10.15.7]
…

com.juul.tuulbox.collections.AtomicMapTests ‑ atomicMap_concurrentMutateBlocks_doesNotLoseWrites[js, browser, ChromeHeadless121.0.6167.184, MacOS10.15.7]
com.juul.tuulbox.collections.AtomicMapTests ‑ atomicMap_mutateAndSnapshot_returnsNewSnapshot[js, browser, ChromeHeadless121.0.6167.184, MacOS10.15.7]
com.juul.tuulbox.collections.AtomicMapTests ‑ atomicMap_snapshotAndMutate_returnsPreviousSnapshot[js, browser, ChromeHeadless121.0.6167.184, MacOS10.15.7]
com.juul.tuulbox.collections.PojoMapTest ‑ toJsObject_whenEmpty_isEmpty[js, browser, ChromeHeadless121.0.6167.184, MacOS10.15.7]
com.juul.tuulbox.collections.PojoMapTest ‑ toJsObject_withArrayValue_stringifiesToSimpleJson[js, browser, ChromeHeadless121.0.6167.184, MacOS10.15.7]
com.juul.tuulbox.collections.PojoMapTest ‑ toJsObject_withMultipleEntries_hasKeys[js, browser, ChromeHeadless121.0.6167.184, MacOS10.15.7]
com.juul.tuulbox.collections.PojoMapTest ‑ toJsObject_withMultipleEntries_hasValues[js, browser, ChromeHeadless121.0.6167.184, MacOS10.15.7]
com.juul.tuulbox.collections.PojoMapTest ‑ toJsObject_withNumberStringPair_stringifiesToSimpleJson[js, browser, ChromeHeadless121.0.6167.184, MacOS10.15.7]
com.juul.tuulbox.collections.PojoMapTest ‑ toJsObject_withStringNumberPair_stringifiesToSimpleJson[js, browser, ChromeHeadless121.0.6167.184, MacOS10.15.7]
com.juul.tuulbox.coroutines.delay.DelayStrategyTest ‑ calculatedDelayResultsInInfinity_returnsMaximumDelayMillis[js, browser, ChromeHeadless121.0.6167.184, MacOS10.15.7]
…

♻️ This comment has been updated with latest results.

Base automatically changed from twyatt/atomicfu to main March 11, 2024 20:55
@twyatt twyatt enabled auto-merge (squash) March 11, 2024 21:29
@twyatt twyatt merged commit adb2ab2 into main Mar 13, 2024
3 checks passed
@twyatt twyatt deleted the twyatt/api branch March 13, 2024 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Phoenix7351 Phoenix7351 Phoenix7351 approved these changes

@QuantumRand QuantumRand QuantumRand approved these changes

Assignees
No one assigned
Labels
maintenance General maintenance that doesn't effect the public API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@twyatt @Phoenix7351 @QuantumRand