Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Have FlowConcurrentMap backed by MutableStateFlow #5

Merged
merged 2 commits into from
May 26, 2020

Conversation

twyatt
Copy link
Member

@twyatt twyatt commented May 25, 2020

Marked the private _onChanged property as nullable (Map<K, V>?) in combination with public onChanged property being exposed via filterNotNull in order to keep the previous behavior (no initial emission).

@twyatt twyatt force-pushed the twyatt/FlowConcurrentMap/MutableStateFlow branch from d71dc7c to 1cf55f0 Compare May 26, 2020 01:00
@codecov
Copy link

codecov bot commented May 26, 2020

Codecov Report

Merging #5 into twyatt/binary-compatibility-validator will not change coverage.
The diff coverage is 85.71%.

Impacted file tree graph

@@                           Coverage Diff                            @@
##             twyatt/binary-compatibility-validator       #5   +/-   ##
========================================================================
  Coverage                                    82.60%   82.60%           
  Complexity                                      18       18           
========================================================================
  Files                                            1        1           
  Lines                                           23       23           
  Branches                                         4        4           
========================================================================
  Hits                                            19       19           
  Misses                                           4        4           
Impacted Files Coverage Δ Complexity Δ
collections/src/main/kotlin/FlowConcurrentMap.kt 82.60% <85.71%> (ø) 18.00 <1.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 218d239...1cf55f0. Read the comment docs.

@twyatt twyatt added this to the 1.0.1 milestone May 26, 2020
@twyatt twyatt marked this pull request as ready for review May 26, 2020 01:07
@twyatt twyatt changed the title Have FlowConcurrentMap be backed by MutableStateFlow Have FlowConcurrentMap backed by MutableStateFlow May 26, 2020
Base automatically changed from twyatt/binary-compatibility-validator to master May 26, 2020 16:42
@twyatt twyatt merged commit 7387464 into master May 26, 2020
@twyatt twyatt deleted the twyatt/FlowConcurrentMap/MutableStateFlow branch May 26, 2020 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants