Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add iOS targets to test module and bump dependencies #61

Merged
merged 8 commits into from
Jun 22, 2021
Merged

Conversation

twyatt
Copy link
Member

@twyatt twyatt commented Jun 18, 2021

@twyatt
Copy link
Member Author

twyatt commented Jun 18, 2021

@cedrickcooke unit test is failing. It appears that the compiler changed anonymous class names.

@Test
fun tagStripsAnonymousClassNumber() {
val supplier = Supplier<String> { StackTraceTagGenerator.getTag() }
// Double check that the way we've written this actually generates
// an anonymous class, instead of being optimized by the compiler.
assertTrue(supplier::class.java.name.endsWith("$1"))
val expected = supplier::class.java.name
.substringAfterLast('.')
.substringBefore("$1")
assertEquals(expected, supplier.get())
}

Printing out supplier::class.java.name shows: com.juul.tuulbox.logging.StackTraceTagGeneratorTests$$Lambda$4/2136709118

I should probably just use a static string ("StackTraceTagGeneratorTests") for the expected?

@cedrickcooke
Copy link
Contributor

This is a legit failure. If they've changed the format for the anonymous class names, then both the expected value and the implementation of StackTraceTagGenerator need to change. I can take a look at finding a new regex that works.

@twyatt

This comment has been minimized.

@cedrickcooke

This comment has been minimized.

@cedrickcooke

This comment has been minimized.

@twyatt

This comment has been minimized.

@twyatt twyatt added this to the 5.0.0 milestone Jun 18, 2021
@codecov
Copy link

codecov bot commented Jun 18, 2021

Codecov Report

❗ No coverage uploaded for pull request base (main@43556d7). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main      #61   +/-   ##
=======================================
  Coverage        ?   94.44%           
  Complexity      ?       51           
=======================================
  Files           ?       13           
  Lines           ?      126           
  Branches        ?        8           
=======================================
  Hits            ?      119           
  Misses          ?        6           
  Partials        ?        1           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 43556d7...b9b707d. Read the comment docs.

@twyatt twyatt marked this pull request as ready for review June 18, 2021 22:19
@twyatt twyatt requested review from a team, QuantumRand and cedrickcooke June 18, 2021 22:19
@twyatt twyatt enabled auto-merge (squash) June 22, 2021 18:20
@twyatt twyatt merged commit e71021d into main Jun 22, 2021
@twyatt twyatt deleted the twyatt/test/apple branch June 22, 2021 20:37
@twyatt twyatt removed this from the 5.0.0 milestone Oct 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants