Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Modded Chests in recipes #143

Closed
IdrisQe opened this issue Mar 3, 2021 · 3 comments
Closed

Support for Modded Chests in recipes #143

IdrisQe opened this issue Mar 3, 2021 · 3 comments
Labels
enhancement New feature or request forge Related to Forge

Comments

@IdrisQe
Copy link

IdrisQe commented Mar 3, 2021

I'm not entirely sure how this could be done easily, given every mod seems to use different tags for their chests, but to use an example, SimpleBackpacks seems to accept BetterEnd chests despite them using different tags as far as I can tell, and not having any explicit integration between the two mods, however Adorn checks very specifically for just vanilla chests, not even using a tag, so they're completely incompatible.

Some Fabric mods with chests that don't work in Adorn recipes include:
-BetterNether
-BetterEnd
-Bewitchment
-Charm
-Sakura Rosea

@IdrisQe IdrisQe added the enhancement New feature or request label Mar 3, 2021
@NovaLynxie
Copy link

NovaLynxie commented Mar 27, 2021

I've seen the exact same occur in the forge version of Adorn.
Some Forge mods which add their own chests include the following: (Quark/Charm have forge versions)
Quark, Charm, Terrain Incognita, Autumity and Environmental.

@Juuxel
Copy link
Owner

Juuxel commented Mar 27, 2021

This is probably easier to fix on Forge. I'm not sure if there's a standardised tag for these on Fabric (though #c:chests might be), but Forge likely has something like #forge:chests.

@NovaLynxie
Copy link

It has forge:chests and forge:chests/wooden. I think the forge:chests/wooden one only looks for wooden ones whereas forge:chests will use any available chest.

@Juuxel Juuxel added the forge Related to Forge label Jun 12, 2021
@Juuxel Juuxel closed this as completed Apr 23, 2022
Juuxel added a commit that referenced this issue Apr 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request forge Related to Forge
Projects
None yet
Development

No branches or pull requests

3 participants