Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix "my" RDS2 as it did not work anymore #20

Closed
wants to merge 1 commit into from

Conversation

tomneda
Copy link
Contributor

@tomneda tomneda commented Feb 19, 2023

After your vastly rebuild of the code and the change to 24000 sample rate of the RDS my RDS2 was not working anymore.
So I could get it run again without many needed changes.

Beside that I did following things, but there are all minor and should not be complicated to integrate:

  • remove not (more) valid comments
  • fix typos and add text in GUI
  • add AGC to IQ scope for RDS1 and RDS3 to be better comparable to RDS2
  • fix usage of switch DO_STEREO_SEPARATION_TEST
  • fix overflow issue in ebu-codetables.c as there is still one of the issue from Andrew left (see the last S with apostrophe here):
    failure_in_RDS

I want to say something about your changes and comments in the code and found also a new issue but I will do that in a private mail.

- remove not (more) valid comments
- fix typos and add text in GUI
- add AGC to IQ scope for RDS1 and RDS3 to be better comparable to RDS2
- fix overflow issue in ebu-codetables.c
@tomneda tomneda mentioned this pull request Feb 25, 2023
@tomneda tomneda closed this Apr 2, 2023
@tomneda tomneda deleted the develop/pr_rds2_fix branch April 2, 2023 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant