Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remaining things after refining #21

Closed
wants to merge 7 commits into from

Conversation

tomneda
Copy link
Contributor

@tomneda tomneda commented Feb 27, 2023

There are still some things left on the master which come from the refactoring (can happen when changing hundred of lines) and other very tiny changes:

  • The zoom factor did not change the x-axis values.
  • A not allowed zoom factor (4 at half side view) led to a "division by zero" (ls-scope.cpp:169).
  • Small correction in README.md and radio.ui.
  • Add excludes to .gitignore for VSCode and JetBrains IDE users (like me :-), beside QTCreator ).
  • I move the compiler switch DO_STEREO_SEPARATION_TEST (not activated) to fmreceiver.pro (CMakeFiles.txt may follow if needed).
  • An initialization issue which meanwhile are longer in the code (since 3276877#diff-017ed302f9eb902069c2e9247a3eab6f556f78c0cd9a2eaeda0f6c2be123ee3aL1009 ): the member "currAttSliderValue" was not more initialized. This doesn't matter unless the IQ balance slider was not touched. In the current AppImage the compiler switch DO_STEREO_SEPARATION_TEST is activated (was that deliberately?) so the IQ balance slider did not use the not initialized member and no problem happens.

The fixes above would not change important things (or show no effects) in the current AppImage or Windows setup. So they need not to be rebuild (imo). But it would be good (gives me a better feeling :-) ) if they are on the mainline.

@tomneda tomneda mentioned this pull request Feb 27, 2023
@tomneda tomneda closed this Apr 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants