Fix CI issues and rubocop offenses #94
Conversation
|
|
||
| # This gem will work with 2.4.0 or greater... but *should* work with 1.8.7+ | ||
| s.required_ruby_version = '>= 2.4.0' | ||
| s.required_ruby_version = '>= 2.7.0' |
There was a problem hiding this comment.
activemodel requires >=2.7.0
ref: https://github.com/rails/rails/blob/main/activemodel/activemodel.gemspec#L12
There was a problem hiding this comment.
This depends on the version of ActiveModel installed.
https://github.com/rails/rails/blob/3-0-stable/activemodel/activemodel.gemspec
This gem requires Ruby 2.4.
|
|
||
| jobs: | ||
| exclude: | ||
| # ref: https://rubies.travis-ci.org/index.txt |
There was a problem hiding this comment.
Latest versions aren't supported for ppc64le.
ref: https://rubies.travis-ci.org/index.txt
There was a problem hiding this comment.
It looks like they are. Where are you seeing that they are not supported?
TravisCI show all of the Rubies that we are testing. https://rubies.travis-ci.org/ They support Ruby 3.1.2 on ppc64le. I don't think that 3.2 was released when I last updated the tested Ruby versions. We should include those newer versions in testing.
I removed Ruby 2.4 form testing because it was having build issues on Travis. Though, IIRC, it would still build and test locally in my VMs.
| @@ -12,15 +12,12 @@ Gem::Specification.new do |s| | |||
| README.md | |||
| CHANGELOG.md | |||
| ] | |||
| s.files = `git ls-files -- lib/*`.split("\n") | |||
There was a problem hiding this comment.
This backquote section occurs build error on JRuby.
There was a problem hiding this comment.
Is that a bug in JRuby? What does it cause a build error?
| s.require_paths = %w[lib] | ||
|
|
||
| s.test_files = `git ls-files -- spec/*`.split("\n") |
There was a problem hiding this comment.
test_files is gone
ref: rubygems/guides#90
There was a problem hiding this comment.
I don't think that this is correct. Please show me where test_files was removed. What commit?
| @@ -2,8 +2,8 @@ Gem::Specification.new do |s| | |||
| s.name = 'email_validator' | |||
| s.version = '2.2.4' | |||
There was a problem hiding this comment.
[NOTICE]
You know, this version needs to bump up before gem push 👻
There was a problem hiding this comment.
This is the current version of this gem.
There was a problem hiding this comment.
I'm not sure why you are mentions this. Is there somewhere that I forgot up bump this? Did the automation fail somewhere? I don't understand why you are bringing this up.
|
@karlwilbur Hello 😄 Could you review this? |
|
What build errors? We should not be removing older Ruby versions from tests since we expect that this should run successfully on those older versions. |
| - 2.7.0 | ||
| - 2.7.6 | ||
| - 3.0.1 | ||
| - 2.7.7 |
There was a problem hiding this comment.
We need to keep these older Ruby versions. I want to ensure that we are testing in the versions that would be used in Rails 3 projects.
There was a problem hiding this comment.
I want to ensure that we are testing in the versions that would be used in Rails 3 projects.
OK
| @@ -16,7 +16,7 @@ AllCops: | |||
| Exclude: | |||
| - 'bin/*' | |||
| NewCops: enable | |||
| TargetRubyVersion: 2.4 | |||
| TargetRubyVersion: 2.7 | |||
There was a problem hiding this comment.
We need to keep the targeted version the same as the minimum version defined in our gemspec.
| s.summary = 'An email validator for Rails 3+.' | ||
| s.description = 'An email validator for Rails 3+. See homepage for details: http://github.com/K-and-R/email_validator' | ||
| s.summary = 'An email validator for Rails.' | ||
| s.description = 'An email validator for Rails. See homepage for details: http://github.com/K-and-R/email_validator' |
| @@ -126,7 +126,7 @@ class DefaultUserWithMessage < TestModel | |||
| "#{v}start-with-#{k}@valid-characters-in-local.dev" | |||
| ]}).concat(valid_endable.map { |k, v| [ | |||
| "end-with-#{k}-#{v}@valid-characters-in-local.dev" | |||
| ]}).concat([ | |||
| ]}).push( | |||
There was a problem hiding this comment.
This is fixed by rubocop.
https://docs.rubocop.org/rubocop/cops_style.html#styleconcatarrayliterals
There was a problem hiding this comment.
Ah, ok. I think we'll leave it unchanged for now.
|
@karlwilbur Thank you for your review 😄 |
Hi ✋
I've just fixed build errors and update Rubies to latest versions.
Also, fixed rubocop offenses using
-ACLI option(Auto correct).Enjoy 😎
P.S I'm ready to be gem owner for continuous maintenance. If you want, plz give me right on Rubygems! Thanks!