Many improvements #3
Conversation
I switched two QLineEdit Field with QComboBox Fields, since those QLineEdit had the user type in a decision between two values.
|
Let's keep the input elements as QLineEdit to allow users to input custom text. The choices are more or less just recommendations for better image generation results. |
There was a problem hiding this comment.
Fix:
src/image/game_info.py:89:5 E303 too many blank lines (2) [pycodestyle]
src/tests/test_character_info.py:24:1 W293 blank line contains whitespace [pycodestyle]
src/tests/test_character_info.py:31:1 W293 blank line contains whitespace [pycodestyle]
src/tests/test_character_info.py:55:1 W293 blank line contains whitespace [pycodestyle]
src/tests/test_game_info.py:18:39 W291 trailing whitespace [pycodestyle]
src/tests/test_game_info.py:34:1 W293 blank line contains whitespace [pycodestyle]
src/tests/test_game_info.py:51:1 W293 blank line contains whitespace [pycodestyle]
src/tests/test_game_info.py:70:1 W293 blank line contains whitespace [pycodestyle]
src/tests/test_game_info.py:87:1 W293 blank line contains whitespace [pycodestyle]
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
improved reusability for mocking for get_game_keywords
improved coding style
First of all I changed UI elements, that were basically a decision of between two elements, that were of Type QLineEdit to QComboBox, giving the User a DropDown Menu. I also added (s)css for those. (Don't forget to recompile with sass).
I also changed (hopefully more or less correct and understandable) the UnitTests to ones that have mocked values, so that the GitHub Actions don't need environment variables anymore. For this I also needed to change some underlying functions, in a way that made the tests easier (or even possible in the first place) without sacrificing the functionality in any way. The UnitTests also required a new library (which can be found in the requirement.txt).