Ensure middleware and reverse ui uses the correct guard #96
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…with multiple guard impersonation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When dealing with multiple guards, the middleware and reverse ui doesn't know which guard is impersonated.
Suppose you have the default
webguard (used for accessing Nova) as well as acustomerguard (used by customers to access your platform). You impersonate thecustomerguard but because Laravel doesn't know which guard you are using, it'll default to using the web guard. This setup means thatauth()->check()is returning false which means that the reverse ui isn't being appended to the layout.This PR corrects this error.