Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

General - Remove Overwrites #488

Merged

Conversation

BrettMayson
Copy link
Contributor

@BrettMayson BrettMayson commented Mar 2, 2024

When merged this pull request will:

  • Chemical is now modular
  • Surgery is now modular
  • Pharma is now modular
  • Create ACE events so that KAM doesn't need to overwrite some files

Semi Related

  • Update to support ACE's new maxDoseDeviation

Requires:

Moved from KAM to ACE:

Currently removed, needs to be added to ACE:

  • Show inactive status setting for medical_gui

IMPORTANT

  • Development Guidelines are read, understood and applied.
  • Title of this PR uses our standard template Component - Add|Fix|Improve|Change|Make|Remove {changes}.

@MissHeda MissHeda added this to the Ongoing milestone Mar 2, 2024
@MissHeda MissHeda added the kind/optimization Release Notes: **IMPROVED:** label Mar 2, 2024
@BrettMayson BrettMayson marked this pull request as ready for review March 3, 2024 00:53
@BrettMayson
Copy link
Contributor Author

Did a basic test of deleting chemical, pharma, and surgery, everything seems to be working just fine. Going to run a test mission with my group.

This would also need a test run by a group that is familiar with the features of chemical, pharma, and surgery, as I am not, and don't plan on using those.

@MiszczuZPolski MiszczuZPolski modified the milestones: Ongoing, 2.14.0 Mar 25, 2024
@MiszczuZPolski MiszczuZPolski merged commit 4f10d52 into KAT-Advanced-Medical:dev-Tomcat Apr 1, 2024
3 checks passed
@BrettMayson BrettMayson deleted the remove_overwrites branch April 1, 2024 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/optimization Release Notes: **IMPROVED:**
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants