Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: heavy iteration on render #40

Merged
merged 2 commits into from
Aug 4, 2022
Merged

fix: heavy iteration on render #40

merged 2 commits into from
Aug 4, 2022

Conversation

grevicoc
Copy link
Contributor

@grevicoc grevicoc commented Aug 4, 2022

Story/Task

refactor populate children when render detail page

Summary

  • change from for loop to for each

Test Plan

Screenshot

image

Delete this

  • Don't Forget to add prefix to PR [Story] Create homepage / [Task] Enhancement
  • Adding label might helpful
  • Fill the template :D
  • Request review to your friend :D
  • Change to merge and squash commit to make more cleaner

@grevicoc grevicoc requested a review from IloveNooodles August 4, 2022 08:00
@grevicoc grevicoc self-assigned this Aug 4, 2022
IloveNooodles
IloveNooodles approved these changes Aug 4, 2022
View reviewed changes
Copy link
Contributor

@IloveNooodles IloveNooodles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved with some comment

.env Outdated Show resolved Hide resolved
@grevicoc grevicoc merged commit 5c6150d into master Aug 4, 2022
@grevicoc grevicoc deleted the fix/for-loop-when-create-childrens branch August 4, 2022 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IloveNooodles IloveNooodles IloveNooodles approved these changes

Assignees

@grevicoc grevicoc

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@grevicoc @IloveNooodles