Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Task] update font style #44

Merged
merged 3 commits into from
Aug 6, 2022
Merged

[Task] update font style #44

merged 3 commits into from
Aug 6, 2022

Conversation

NoobiesDoobies
Copy link
Contributor

@NoobiesDoobies NoobiesDoobies commented Aug 6, 2022 •
edited by IloveNooodles
Loading

Story/Task

  • [Task] Used the standard font style (heading, subheading, ...)

Summary

Base Layout:

  • DEVA 2022 - Content and Publication -> caption
  • Find us on -> caption

About page:

  • About content -> subheading
  • See more -> title

About detail page:

  • About detail content -> body
  • Go back -> title

Partner page:

  • Thanks to, sponsored by, media partner menggunakan constant dan font-Heading

Pagination:

  • Page number -> subheading

Search page:

  • Filter tags -> subheading
  • Tags -> body

Detail page:

  • Title -> heading
  • Author -> subheading
  • Date -> subheading
  • Inner node text -> body

Test Plan

  • Font style will change for every page

Screenshot

https://docs.google.com/document/d/1nfLXoIk5fekzKCMt5rhQbkC08L-NtzKmM5H43dVwFjk/edit#

IloveNooodles
IloveNooodles approved these changes Aug 6, 2022
View reviewed changes
Copy link
Contributor

@IloveNooodles IloveNooodles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtmm, jangan lupa resolve conflictnya yaa

@NoobiesDoobies NoobiesDoobies merged commit f3b5d7a into master Aug 6, 2022
@NoobiesDoobies NoobiesDoobies deleted the task/update-font-style branch August 6, 2022 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IloveNooodles IloveNooodles IloveNooodles approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@NoobiesDoobies @IloveNooodles