Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fix] refactor parse for figure #52

Merged
merged 5 commits into from
Aug 9, 2022
Merged

[Fix] refactor parse for figure #52

merged 5 commits into from
Aug 9, 2022

Conversation

ranjabi
Copy link
Contributor

@ranjabi ranjabi commented Aug 9, 2022 •
edited
Loading

Story/Task

Fix figure such as image, video, youtube, twitter, spotify, gallery

Summary

  • Add figure attribute interface
  • Add attribute parser
  • _Add caption and alt for image
    _

Test Plan

Add figure element

Screenshot

image
image

@ranjabi ranjabi requested a review from IloveNooodles August 9, 2022 07:19
IloveNooodles
IloveNooodles approved these changes Aug 9, 2022
View reviewed changes
Copy link
Contributor

@IloveNooodles IloveNooodles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

semua yg undefined mau diganti null aja ga? ada alesan spesifil kenapa make undefined?

src/pages/Detailpage/Render.tsx Show resolved Hide resolved
@IloveNooodles IloveNooodles merged commit 6e515e4 into master Aug 9, 2022
@IloveNooodles IloveNooodles deleted the fix/refactor-parse branch August 9, 2022 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IloveNooodles IloveNooodles IloveNooodles approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ranjabi @IloveNooodles @grevicoc