Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Story] Add detail page but only text, image, and video component that can get rendered #7

Merged
merged 8 commits into from
Jul 26, 2022
Merged

[Story] Add detail page but only text, image, and video component that can get rendered #7

merged 8 commits into from
Jul 26, 2022

Conversation

grevicoc
Copy link
Contributor

i think this is not done yet, need:

  • use useFetch instead manual axios
  • add vistocks
  • add conditions so other component can get rendered
  • make automatically call api get specific post

why i open this PR is to request review from the others about my code, im sorry it's so hard to just make this program running:(

@grevicoc grevicoc self-assigned this Jul 21, 2022
@IloveNooodles IloveNooodles changed the title feat: add detail page but only text, image, and video component that can get rendered [Story add detail page but only text, image, and video component that can get rendered Jul 21, 2022
@IloveNooodles IloveNooodles changed the title [Story add detail page but only text, image, and video component that can get rendered [Story] Add detail page but only text, image, and video component that can get rendered Jul 21, 2022
IloveNooodles
IloveNooodles requested changes Jul 22, 2022
View reviewed changes
Copy link
Contributor

@IloveNooodles IloveNooodles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

kalo video youtube udah dicoba? bisa di list yg blum dikerjain apa aja?

src/pages/Detailpage/Detailpage.tsx Outdated Show resolved Hide resolved
@tito-feedloop
Copy link

tito-feedloop commented Jul 22, 2022 •
edited by IloveNooodles
Loading

  • Markdown
  • HTML
  • Gallery
  • Divider
  • Bookmark
  • Email content
  • Email call to action
  • Public preview
  • Button
  • Callout
  • Toggle
  • Audio
  • File
  • Product
  • Header
  • Youtube URL
  • Twitter URL
  • Unsplash URL
  • Vimeo URL
  • CodePen URL
  • Spotify URL
  • SoundCloud URL
  • NFT URL
  • Others URL
  • Ordered List
  • Unordered List

Boleh tolong dipilih @IloveNooodles yang prioritas dikerjain yang mana, biar gue ama januar prioritasin itu dulu

@IloveNooodles IloveNooodles added the enhancement New feature or request label Jul 22, 2022
IloveNooodles
IloveNooodles approved these changes Jul 22, 2022
View reviewed changes
Copy link
Contributor

@IloveNooodles IloveNooodles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved with some comment

src/pages/Homepage/Homepage.tsx Show resolved Hide resolved
@grevicoc grevicoc merged commit 6f64a8e into master Jul 26, 2022
@grevicoc grevicoc deleted the story/detailpage branch July 26, 2022 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tito-feedloop tito-feedloop tito-feedloop left review comments

@IloveNooodles IloveNooodles IloveNooodles approved these changes

Assignees

@grevicoc grevicoc

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@grevicoc @tito-feedloop @IloveNooodles @buditato