generated from KATITB22/Template-FE
-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Story] Add header footer layout #8
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IloveNooodles
approved these changes
Jul 22, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
IloveNooodles
added a commit
that referenced
this pull request
Jul 26, 2022
* feat: adding FontSize, Color and Font Constant * feat: adding spinner, adding loadingpage * feat: adding constant, route not found, and loading * feat: setup font on local * Create pull_request.template.md * Rename pull_request.template.md to pull_request_template.md * Update pull_request_template.md * feat: add about page * feat: add about page * refactor: using map for paragraph * Note: still using dummy content. * [Story] Homepage - add BlogPost component (#3) * feat: add BlogPost component * add props & delete antd * fix: remove error * feat: add oskm logo and name in index * [Story] Adding Search Page and Filter Search Component (#4) * feat: rebasing from main * feat: finish responsive for search * refactor: renaming color classname (#5) * [Story] Homepage - Responsive BlogPost component and Homepage (#6) * feat: add BlogPost component * add props & delete antd * change BlogPost using tailwind * style: reponsive on homepage * feat: add useFetch hooks * fix: typo * feat: adding react motion * style: adding radius to blogspot and fix size * feat: add detail page but only text, image, and video componenet that can get rendered * feat: add detail page but only text, image, and video componenet that can get rendered * refactor: move component rendering as a module * feat: styling text (bold/italic), ol/ul (ul still buggy), heading * feat: integrate home to detailpage * [Story] Create partner page (#9) * feat: add initial box layout * feat: add containers for sponsor, medpar, and infographics * feat: insert sponsor images * style: change font, feat: add image array * fix: fix image array * [Story] Add header footer layout (#8) * merge from master * activate hooks * Add header. TODO: fix theme color, add logo, add footer * add header and footer * Styling: Fixing code styling * feat: add header and footer * feat: add header and footer * fix: environment * feat: integrate homepage Co-authored-by: Fikri Ranjabi <71055612+ranjabi@users.noreply.github.com> Co-authored-by: Shafira Naya <67799407+shafiranaya@users.noreply.github.com> Co-authored-by: Muhammad Tito Prakasa <cocabc1@gmail.com> Co-authored-by: buditato <datajanoe@gmail.com> Co-authored-by: auliaadila <63394328+auliaadila@users.noreply.github.com> Co-authored-by: Widya Anugrah Putra <55840245+widyaput@users.noreply.github.com>
IloveNooodles
added a commit
that referenced
this pull request
Jul 26, 2022
* feat: adding FontSize, Color and Font Constant * feat: adding spinner, adding loadingpage * feat: adding constant, route not found, and loading * feat: setup font on local * Create pull_request.template.md * Rename pull_request.template.md to pull_request_template.md * Update pull_request_template.md * feat: add about page * feat: add about page * refactor: using map for paragraph * Note: still using dummy content. * [Story] Homepage - add BlogPost component (#3) * feat: add BlogPost component * add props & delete antd * fix: remove error * feat: add oskm logo and name in index * [Story] Adding Search Page and Filter Search Component (#4) * feat: rebasing from main * feat: finish responsive for search * refactor: renaming color classname (#5) * [Story] Homepage - Responsive BlogPost component and Homepage (#6) * feat: add BlogPost component * add props & delete antd * change BlogPost using tailwind * style: reponsive on homepage * feat: add useFetch hooks * fix: typo * feat: adding react motion * style: adding radius to blogspot and fix size * feat: add detail page but only text, image, and video componenet that can get rendered * feat: add detail page but only text, image, and video componenet that can get rendered * refactor: move component rendering as a module * feat: styling text (bold/italic), ol/ul (ul still buggy), heading * feat: integrate home to detailpage * [Story] Create partner page (#9) * feat: add initial box layout * feat: add containers for sponsor, medpar, and infographics * feat: insert sponsor images * style: change font, feat: add image array * fix: fix image array * [Story] Add header footer layout (#8) * merge from master * activate hooks * Add header. TODO: fix theme color, add logo, add footer * add header and footer * Styling: Fixing code styling * feat: add header and footer * feat: add header and footer * fix: environment * feat: integrate homepage Co-authored-by: Fikri Ranjabi <71055612+ranjabi@users.noreply.github.com> Co-authored-by: Shafira Naya <67799407+shafiranaya@users.noreply.github.com> Co-authored-by: Muhammad Tito Prakasa <cocabc1@gmail.com> Co-authored-by: buditato <datajanoe@gmail.com> Co-authored-by: IloveNooodles <mgarebaldhie80@gmail.com> Co-authored-by: auliaadila <63394328+auliaadila@users.noreply.github.com> Co-authored-by: Widya Anugrah Putra <55840245+widyaput@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Story/Task
Create Layout
Summary
Test Plan