Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing PartialEq for QVariant #487

Closed
ahayzen-kdab opened this issue Mar 24, 2023 Discussed in #486 · 1 comment · Fixed by #490
Closed

Missing PartialEq for QVariant #487

ahayzen-kdab opened this issue Mar 24, 2023 Discussed in #486 · 1 comment · Fixed by #490
Assignees
@vimpostor
Labels
🪲 bug Something isn't working

Comments

@ahayzen-kdab
Copy link
Collaborator

Discussed in #486

Originally posted by antroids March 24, 2023
Hi there,

Trying to figure out how to use the library and noticed that cxx_qt_lib::QHash<cxx_qt_lib::QHashPair_QString_QVariant> cannot be used as #[qproperty] due to missing PartialEq impl for QVariant. The comparison is used in generated setter.
Is it intended or just not implemented yet?
@ahayzen-kdab ahayzen-kdab added the 🪲 bug Something isn't working label Mar 24, 2023
@ahayzen-kdab
Copy link
Collaborator Author

@vimpostor was there a reason QVariant was skipped ? Eg it should have at least PartialEq right ?

@ahayzen-kdab ahayzen-kdab mentioned this issue Mar 24, 2023
Closed
10 tasks
vimpostor added a commit to vimpostor/cxx-qt that referenced this issue Mar 27, 2023
@vimpostor
Implement PartialEq for QVariant
282d39a 
This fixes #[qproperty] not being available for QVariant, because the
generated setter would use the equality operator.

Fixes KDAB#487
@vimpostor vimpostor mentioned this issue Mar 27, 2023
Merged
vimpostor added a commit to vimpostor/cxx-qt that referenced this issue Mar 27, 2023
@vimpostor
Implement PartialEq for QVariant
b88e3de 
This fixes #[qproperty] not being available for QVariant, because the
generated setter would use the equality operator.

Fixes KDAB#487
vimpostor added a commit that referenced this issue Mar 27, 2023
@vimpostor
Implement PartialEq for QVariant (#490)
abe72d1 
This fixes #[qproperty] not being available for QVariant, because the
generated setter would use the equality operator.

Fixes #487
ahayzen-kdab pushed a commit to ahayzen-kdab/cxx-qt that referenced this issue Mar 27, 2023
@vimpostor @ahayzen-kdab
Implement PartialEq for QVariant (KDAB#490)
afda830 
This fixes #[qproperty] not being available for QVariant, because the
generated setter would use the equality operator.

Fixes KDAB#487
ahayzen-kdab pushed a commit that referenced this issue Mar 27, 2023
@vimpostor @ahayzen-kdab
Implement PartialEq for QVariant (#490)
5523f95 
This fixes #[qproperty] not being available for QVariant, because the
generated setter would use the equality operator.

Fixes #487
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vimpostor vimpostor

Labels
🪲 bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Implement PartialEq for QVariant vimpostor/cxx-qt
2 participants
@vimpostor @ahayzen-kdab