Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

qt-build-utils: use QML module name in .qrc file name #755

Merged
merged 1 commit into from
Nov 27, 2023
Merged

qt-build-utils: use QML module name in .qrc file name #755

merged 1 commit into from
Nov 27, 2023

Conversation

Be-ing
Copy link
Contributor

@Be-ing Be-ing commented Nov 25, 2023

This is required to link together multiple QML modules in one project without duplicate symbol errors. This fixes the link error in #598.

@Be-ing
qt-build-utils: use QML module name in .qrc file name
e7102c9 
This is required to link together multiple QML modules in one
project without duplicate symbol errors.
@Be-ing Be-ing mentioned this pull request Nov 25, 2023
Draft
ahayzen-kdab
ahayzen-kdab approved these changes Nov 27, 2023
View reviewed changes
Copy link
Collaborator

@ahayzen-kdab ahayzen-kdab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome thanks for spotting that :-) 🎉

@ahayzen-kdab ahayzen-kdab merged commit 588d1f5 into KDAB:main Nov 27, 2023
6 checks passed
@Be-ing Be-ing deleted the qml_module_qrc_name branch November 27, 2023 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahayzen-kdab ahayzen-kdab ahayzen-kdab approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Be-ing @ahayzen-kdab