cxx-qt-build: set minimum macOS version #825
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
to override cc's default which is too low for CXX-Qt
|
Fun issue on Linux cargo:warning=Compiler version doesn't include clang or GCC: "/usr/bin/c++" "--version"
cargo:warning=as: unrecognized option '-mbig-obj'
exit status: 1 |
|
Yeah I saw that... pretty puzzled why this change would make that show up. |
| // We need | ||
| // - std::filesystem::path from 10.15 | ||
| // - std::shared_mutex from 10.12 | ||
| builder.apple_deployment_target(&"10.5"); |
There was a problem hiding this comment.
does the upstream change mean we still need this ? rust-lang/cc-rs#943 Sounds like it reads the SDK's DefaultDeploymentTarget again ?
There was a problem hiding this comment.
nah let's close this
|
Superseded by #848 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to override cc's default which is too low for CXX-Qt. Setting the MACOSX_DEPLOYMENT_TARGET environment variable in CI is fine, but that doesn't solve the problem for downstream users.
relies on a pending PR for cc rust-lang/cc-rs#938