Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

includemocs: include MOC file at the earliest possible opportunity if… #34

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

includemocs: include MOC file at the earliest possible opportunity if… #34

wants to merge 1 commit into from

Commits on Aug 26, 2024

  1. includemocs: include MOC file at the earliest possible opportunity if… 

    … header file is not found

The script expects to find header file include with relative path. However, if absolute path is used (e.g. #include "path/to/header.h" instead of #include "header.h") the check will return 0 as insertion position. This, however, can (and often will) conflict with license/copyright comment meaning MOC file will be included before license/copyright comment.

Furthermore, clang-format is unable to re-sort headers if they're separated by code or comments, if this check is event enabled at all. And so, this means that user would have to manually adjust every file.

This patch add additional attempt at finding #include directive and if it is found, MOC file will be included before the first occurrence of the #include directive. This somewhat guarantees that license/copyright header has been skipped.

This change, of course, doesn't fix all the possible issues, but only attempts to mitigate a common instance of such case.
    @Poldraunic
    Poldraunic committed Aug 26, 2024
    Configuration menu
    Copy the full SHA
    69e3ccd View commit details
    Browse the repository at this point in the history