chore: polkadot 0.9.42 #527

Ad96el · 2023-05-30T12:02:25Z

fixes KILTProtocol/ticket#2693

Updates to Polkadot dependencies have been made to version 0.9.42. You can find all the changes here.

How to test

Since the Currency trait has been silently deprecated, the unit tests have been adjusted to support the newly introduced fungible traits. Pre- and post-validations have been implemented for the migrations.

Still to be updated

In all pallets where a negative imbalance is used, the Currency trait is still being used. The feecollector (the treasury pallet) has not been updated yet, and there is an open PR addressing this. If the PR is merged, we will be able to completely remove the Currency trait. Currently, the trait is still used in the staking, DID, and CType pallets.

Checklist:

I have verified that the code works
- No panics! (checked arithmetic ops, no indexing array[3] use get(3), ...)
I have verified that the code is easy to understand
- If not, I have left a well-balanced amount of inline comments
I have left the code in a better state
I have documented the changes (where applicable)
- Either PR or Ticket to update the Docs
- Link the PR/Ticket here

pallets/parachain-staking/src/migrations.rs

ntn-x2

Mostly looks good. I have some minor points about the migration stuff and few typos in the staking pallet. The biggest point is about the use of .uwnrap() inside the did::create pallet, which is no-good for the runtime logic. It is ok for it to fail instead.

pallets/attestation/src/migrations.rs

pallets/did/src/lib.rs

pallets/pallet-configuration/Cargo.toml

pallets/parachain-staking/src/lib.rs

ntn-x2

I think a lot has been improved since when the PR has been opened. I am happy with all the changes made. As I said, the only thing that might need to be done in a separate PR is a multi-block migration strategy, if needed. Also, we need to check that the logic for account reaping/dust collection has remained the same. I think @weichweich will still have to review this, at some point. But I will approve it on my side.

weichweich · 2023-07-10T11:24:11Z

pallets/attestation/src/lib.rs

-		fn remove_attestation(attestation: AttestationDetailsOf<T>, claim_hash: ClaimHashOf<T>) {
-			kilt_support::free_deposit::<AccountIdOf<T>, CurrencyOf<T>>(&attestation.deposit);
+		fn remove_attestation(attestation: AttestationDetailsOf<T>, claim_hash: ClaimHashOf<T>) -> DispatchResult {
+			AttestationStorageDepositCollector::<T>::free_deposit(attestation.deposit)?;


What are possible errors when freeing the deposit and what would this mean for remove_attestation?
I fear that if the error occurs, that there is no possible option to remove the attestation without the governance?

There are two possible cases where remove attestation can fail:

The user does not have enough balance on their hold, and the decrease should be Exact. If the precision is set to BestEffort, the actual amount is returned in an Ok response.

Even after increasing the free balance, the user is still under the ED.

As I see it, both cases can be ignored. In the first case, the actual deposit is tracked in the storage. Additionally, when an attestation is removed, we use BestEffort as the precision.

support/src/lib.rs

pallets/attestation/src/migrations.rs

weichweich · 2023-07-10T11:51:14Z

pallets/attestation/src/migrations.rs

+	Attestations::<T>::iter()
+		.map(|(key, attestations_detail)| -> Weight {


How many attestations do we have? I'm afraid that this is not an option for us? Especially since we not only iterate over all attestations but basically over all storage?

pallets/delegation/src/lib.rs

pallets/did/src/lib.rs

pallets/pallet-web3-names/src/lib.rs

runtimes/spiritnet/src/weights/pallet_balances.rs

weichweich · 2023-07-11T09:27:17Z

Looks good. But the migration has to be redone. I don't think that we can do that in a single block. I propose we do a lazy migration with a permission less call to update them. Like it was suggested in the PR.

weichweich · 2023-07-13T07:15:48Z

Cargo.lock

@@ -562,7 +579,7 @@ dependencies = [
 [[package]]
 name = "binary-merkle-tree"
 version = "4.0.0-dev"
-source = "git+https://github.com/paritytech/substrate?branch=polkadot-v0.9.41#3bd809d59c31c7205a0f36c6ddcba603e43051fc"
+source = "git+https://github.com/paritytech/substrate?branch=polkadot-v0.9.42#3bb3882ce094ac211dea93fabfdcd4f902f5a7fd"


You don't seem to be up to date with polkadot-v0.9.42. Try running cargo update. This will update all dependencies. You could run cargo update -p sp-io which updates most of the substrate dependencies. Make sure to also check cumulus & polkadot repositories.

ntn-x2

Did not go over everything, but I like this approach more of migrating a specific account to the new version.

ntn-x2 · 2023-07-18T14:32:31Z

pallets/attestation/src/migrations.rs

@@ -163,10 +150,7 @@ pub mod test {
 				assert!(attestation_post_migration.clone().unwrap().deposit.version.is_some());
 				assert!(attestation_post_migration.unwrap().deposit.version.unwrap() == 1);

-				//Nothing should happen


Maybe you can keep the comment?

Ad96el added 25 commits May 5, 2023 14:23

update to 0.9.40

4a6d68d

no warnings. two errors

fa6b054

service file fix

8ddacc2

chore: finished v0.9.40

e649737

version 0.9.41

c699de5

intermediate state

d461d2e

compiling

11983e8

With metadata runtime api

d0c6a86

With metadata runtime api

b2f69ca

working tests

7337c8a

first draft

771a420

merge develop into chore/polkadot-0.9.41

6986d47

first draft

601a580

fmt

633beb2

2 errors

88a10cc

resolved merge conflicts

e2542e0

merge develop into chore/polkadot-0.9.42

3e1e296

with working tests

b9e23a2

working and finished

b47d04a

tests

cfb846c

refactor

737f675

refactor

9a565ed

refactor pallet-did-lookup

206a8da

remove reservableCurrency

4786f95

update weights

f18bc38

Ad96el changed the title ~~Chore/polkadot 0.9.42~~ chore: polkadot 0.9.42 May 31, 2023

Ad96el added 4 commits May 31, 2023 14:27

refactor files

861b7c1

intermediate state

8d121e9

sharing is caring

5f67e2f

improved HFidentifier plus comments

fa11d9d

Ad96el added 2 commits July 3, 2023 11:10

improved free_deposit

68aa397

remove artefact

4f1d80c

Ad96el commented Jul 3, 2023

View reviewed changes

pallets/parachain-staking/src/migrations.rs Outdated Show resolved Hide resolved

merge develop into chore/polkadot-0.9.42

31d2d86

Ad96el requested a review from weichweich July 3, 2023 09:34

ntn-x2 requested changes Jul 10, 2023

View reviewed changes

Ad96el added 8 commits July 10, 2023 15:10

typos

6520dc2

no unwrap

45a2be7

freeze reason

e0edef0

less ensure

7201f7f

update cargo toml

bbbd93e

update migration

f4a1479

update weights function

be9f2e5

revert: less ensure

f9b4fb7

Ad96el requested a review from ntn-x2 July 10, 2023 16:44

other precision and preservation

1de9ed9

ntn-x2 approved these changes Jul 11, 2023

View reviewed changes

merge develop into chore/polkadot-0.9.42

7ab63bb

weichweich reviewed Jul 11, 2023

View reviewed changes

Ad96el added 3 commits July 11, 2023 13:13

license

faf9f53

mod order

873b4fb

use ==

b2fe45e

weichweich reviewed Jul 13, 2023

View reviewed changes

ntn-x2 reviewed Jul 18, 2023

View reviewed changes

Ad96el force-pushed the chore/polkadot-0.9.42 branch from dc34cbc to b2fe45e Compare July 20, 2023 07:13

Merge branch 'develop' into chore/polkadot-0.9.42

bf1e429

Ad96el merged commit 721bbb0 into develop Jul 20, 2023

Ad96el deleted the chore/polkadot-0.9.42 branch July 20, 2023 09:24

b-yap mentioned this pull request Aug 24, 2023

Update runtimes to polkadot-v0.9.42 pendulum-chain/pendulum#303

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore: polkadot 0.9.42 #527

chore: polkadot 0.9.42 #527

Ad96el commented May 30, 2023 •

edited

Loading

ntn-x2 left a comment

ntn-x2 left a comment

weichweich Jul 10, 2023

Ad96el Jul 11, 2023

weichweich Jul 10, 2023

weichweich commented Jul 11, 2023

weichweich Jul 13, 2023

ntn-x2 left a comment

ntn-x2 Jul 18, 2023

		Attestations::<T>::iter()
		.map(\|(key, attestations_detail)\| -> Weight {

chore: polkadot 0.9.42 #527

chore: polkadot 0.9.42 #527

Conversation

Ad96el commented May 30, 2023 • edited Loading

fixes KILTProtocol/ticket#2693

How to test

Still to be updated

Checklist:

ntn-x2 left a comment

Choose a reason for hiding this comment

ntn-x2 left a comment

Choose a reason for hiding this comment

weichweich Jul 10, 2023

Choose a reason for hiding this comment

Ad96el Jul 11, 2023

Choose a reason for hiding this comment

weichweich Jul 10, 2023

Choose a reason for hiding this comment

weichweich commented Jul 11, 2023

weichweich Jul 13, 2023

Choose a reason for hiding this comment

ntn-x2 left a comment

Choose a reason for hiding this comment

ntn-x2 Jul 18, 2023

Choose a reason for hiding this comment

Ad96el commented May 30, 2023 •

edited

Loading