fix: remove dotnames #862
Draft
fix: remove dotnames #862
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request removes the
unique-linkinganddot-namespallet implementations. However, the pallet changes are retained, as they might be useful in the future.All related implementations, including the runtime API, runtime commons, benchmarking, migrations, and miscellaneous components, are removed.
For Peregrine, a migration is introduced to remove the already deployed pallets. For Spiritnet, the pallet implementation in the runtime construction is removed without additional comments.
Key changes include:
Removal of
unique-linking-runtime-api:Cargo.toml: Removed theunique-linking-runtime-apidependency.runtime-api/unique-linking/Cargo.toml: Deleted the entire file, removing the package definition and dependencies.runtime-api/unique-linking/src/lib.rs: Deleted the entire file, removing the runtime API implementation for unique linking.Code Cleanup in Runtimes:
runtimes/common/src/lib.rs: Removed thedot_namesmodule import.runtimes/common/src/dot_names/mod.rs: Deleted the entire file, removing related structures and logic.runtimes/common/src/dot_names/origin.rs: Deleted the entire file, removing origin-related logic for dot names and unique linking.runtimes/common/src/dot_names/tests.rs: Deleted the entire file, removing tests for dot names validation.Updates to Peregrine Runtime:
runtimes/peregrine/Cargo.toml: Removedunique-linking-runtime-apifrom dependencies and feature list. [1] [2]runtimes/peregrine/src/benchmarks/mod.rs: Removed references toDotNamesandUniqueLinkingin benchmarks. [1] [2]runtimes/peregrine/src/benchmarks/web3_names.rs: RemovedDotNamesBenchmarkHelper.runtimes/peregrine/src/kilt/did.rs: Removed logic related toDotNamesandUniqueLinkingfrom DID call authorization and deletion hooks. [1] [2] [3]