fix: cbor-web imports do not work in esm #772
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@arty-name what I could do to make this a little nicer is move that import magic to a file in the utils package, and then import from there? |
arty-name
approved these changes
Jun 14, 2023
Hope that's better? |
rflechtner
added a commit
that referenced
this pull request
Jun 14, 2023
* fix: cbor-web imports do not work in esm (#772) * chore: set release version 0.33.1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes KILTProtocol/ticket#2749
Fixes a broken import in esm code. The fix is ugly, but it's actually what a recent post on dual-esm-cjs libraries recommends (https://evertpot.com/universal-commonjs-esm-typescript-packages/)
How to test:
I tried importing the relevant functions in both an mjs and a cjs script, that worked.
Checklist: