-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor!: credentialSchema does not work for CTypes #774
Conversation
4b01737
to
1131d50
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Your comments make sense.
@ntn-x2 I did have a concern that |
It would make sense, right? This is pretty much tied to what we do in this version of the spec. |
fixes KILTProtocol/ticket#2747
We finally have a proper draft spec for JSON-schema descriptions of VCs - but this is not particularly compatible with our CTypes, and the latest CType version we released is even less likely to work with this.
So I wanted to explore what it would look like if we used this field for something else - namely for describing what a KiltCredentialV1 type VC has to look like. CType verification would then have to be moved elsewhere; I think it's best here to just do it as part of credential verification.
Done so far:
JsonSchema2023
and the id references the our credential schema for KiltCredentialV1 type credentials.type
field?).How to test:
Please provide a brief step-by-step instruction.
If necessary provide information about dependencies (specific configuration, branches, database dumps, etc.)
Checklist: