Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: rename Docker image #902

Merged
merged 4 commits into from
Sep 5, 2024
Merged

fix: rename Docker image #902

merged 4 commits into from
Sep 5, 2024

Conversation

ntn-x2
Copy link
Member

@ntn-x2 ntn-x2 commented Sep 4, 2024

The Docker image specified there never existed, and it's only used internally for cache.

@ntn-x2 ntn-x2 self-assigned this Sep 4, 2024
@rflechtner
Copy link
Contributor

The kilt/prototype-chain image very much did exist on our ECR and we're using it everywhere in our sdk tests.
@ggera can you confirm which image name we should be using? Can we maybe just configure ECS to act as a pull-through cache for kiltprotocol/standalone-node?

@ntn-x2
Copy link
Member Author

ntn-x2 commented Sep 5, 2024

Yes it does, but as far as I can see it's only used as an intermediate cache to build standalone-node Docker images. If @ggera agrees, we should probably switch SDK tests to use the standalone-node Docker image, and in the future perhaps even a Zombienet-based setup with the kilt-node Docker image directly, which I am working on.

@ntn-x2
Copy link
Member Author

ntn-x2 commented Sep 5, 2024

Anyway I'm a bit confused, cause here we use kiltprotocol/standalone-node:latest-develop instead.

@ntn-x2
Copy link
Member Author

ntn-x2 commented Sep 5, 2024

It seems we are not pushing there anymore @ggera? That is what I figured by looking at our deployment pipelines, although I think it was introduced with your refactoring. Since it's used as a caching image, perhaps we want to replace it completely in our build pipeline and in the integration tests to use the standalone image rather? This one has pushes from the current release process.

Screenshot 2024-09-05 at 10 59 36

@ntn-x2
Copy link
Member Author

ntn-x2 commented Sep 5, 2024

Link to the manually-triggered GitHub workflow being changed here: https://github.com/KILTprotocol/sdk-js/actions/runs/10717708953/job/29718068093. This seems to work now.

Copy link
Member

@Dudleyneedham Dudleyneedham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rflechtner
Copy link
Contributor

We need a cache layer to get around dockerhub rate limits. That's why I suggested a pull through cache

Copy link
Contributor

@rflechtner rflechtner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is standalone-node an image that's being updated on our ECR?

@rflechtner
Copy link
Contributor

If this is the image we should be using, can you update all workflows to use it?

@ntn-x2
Copy link
Member Author

ntn-x2 commented Sep 5, 2024

Yes, standalone-node has always been updated, that's why I was confused. I still don't know if stop pushing to the prototype-chain image was intentional or not, but I can definitely update the image used everywhere.

@ntn-x2
Copy link
Member Author

ntn-x2 commented Sep 5, 2024

@rflechtner I talked to @ggera and we don't see any issue in using the final Docker image for all tests, so I updated all references. Once he's back, we'll investigate if we need such an intermediate image, and how to deal with it.

Copy link
Contributor

@rflechtner rflechtner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@ntn-x2
Copy link
Member Author

ntn-x2 commented Sep 5, 2024

The CI fails because the latest tag is broken, but both the latest rc as well as develop work, so I'll merge this. latest will be fixed as soon as we promote the rc.

@ntn-x2 ntn-x2 merged commit 3af92aa into develop Sep 5, 2024
10 of 14 checks passed
@ntn-x2 ntn-x2 deleted the aa/fix-node-integration-tests branch September 5, 2024 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants