-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: rename Docker image #902
Conversation
The kilt/prototype-chain image very much did exist on our ECR and we're using it everywhere in our sdk tests. |
Yes it does, but as far as I can see it's only used as an intermediate cache to build |
Anyway I'm a bit confused, cause here we use |
It seems we are not pushing there anymore @ggera? That is what I figured by looking at our deployment pipelines, although I think it was introduced with your refactoring. Since it's used as a caching image, perhaps we want to replace it completely in our build pipeline and in the integration tests to use the standalone image rather? This one has pushes from the current release process. |
Link to the manually-triggered GitHub workflow being changed here: https://github.com/KILTprotocol/sdk-js/actions/runs/10717708953/job/29718068093. This seems to work now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
We need a cache layer to get around dockerhub rate limits. That's why I suggested a pull through cache |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is standalone-node
an image that's being updated on our ECR?
If this is the image we should be using, can you update all workflows to use it? |
Yes, |
@rflechtner I talked to @ggera and we don't see any issue in using the final Docker image for all tests, so I updated all references. Once he's back, we'll investigate if we need such an intermediate image, and how to deal with it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm
The CI fails because the |
The Docker image specified there never existed, and it's only used internally for cache.