Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Only build mpy files when kmk library files changed #857

Merged
merged 2 commits into from
Aug 31, 2023
Merged

feat: Only build mpy files when kmk library files changed #857

merged 2 commits into from
Aug 31, 2023

Conversation

grasegger
Copy link
Contributor

close #818

@grasegger
Copy link
Contributor Author

I am very confused by the tests failing ...

Also I was not sure about using an include or exclude, since I am not sure what files are needed for building I started with an exclude

@grasegger
Copy link
Contributor Author

Running make test locally "just works", can I get feedback about the nature of the fail? I am not deep into python and the error does not make immediate sense to me.

@xs5871
Copy link
Collaborator

xs5871 commented Aug 19, 2023

Many of our unit tests are dependent on timing and timeouts.
Occasionally and somewhat randomly, some tests fail to meet their race conditions. Re-running the tests is the "fix".

@xs5871 xs5871 mentioned this pull request Aug 30, 2023
Closed
@grasegger
Copy link
Contributor Author

@xs5871 if we're going with an Allowlist I would suggest to include the make- and pipfiles, otherwise one could push build-breaking changes that would only fail once KMK changes again.

@xs5871
Copy link
Collaborator

xs5871 commented Aug 31, 2023

I don't understand. Neither Makefile nor Pipfile are involved in the mpy compliation process.

@grasegger
Copy link
Contributor Author

Then ignore my comment, sorry 🙈

@xs5871 xs5871 merged commit 642dbff into KMKfw:master Aug 31, 2023
1 check passed
xs5871 added a commit that referenced this pull request Oct 17, 2023
@grasegger @xs5871
feat: Only build mpy files when kmk library files changed (#857)
227ce04 
---------

Co-authored-by: Karl Grasegger <gruenesgnu@posteo.de>
Co-authored-by: xs5871 <60395129+xs5871@users.noreply.github.com>
hixan pushed a commit to hixan/kmk_firmware that referenced this pull request Nov 25, 2023
@grasegger @xs5871
feat: Only build mpy files when kmk library files changed (KMKfw#857)
6b60f80 
---------

Co-authored-by: Karl Grasegger <gruenesgnu@posteo.de>
Co-authored-by: xs5871 <60395129+xs5871@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xs5871 xs5871 xs5871 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Enhancement] Generate mpy artifacts only on changed source
2 participants
@grasegger @xs5871