New spellcheck #858
Merged
New spellcheck #858
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* requires aspell be installed and on your path * add `make spellcheck` command
xs5871
requested changes
Aug 22, 2023
xs5871
approved these changes
Aug 28, 2023
xs5871
pushed a commit
that referenced
this pull request
Oct 17, 2023
Add spellchecking script and make target for english docs --------- Co-authored-by: Ryan Rotter <rrotter@users.noreply.github.com> Co-authored-by: Karl Grasegger <gruenesgnu@posteo.de>
hixan
pushed a commit
to hixan/kmk_firmware
that referenced
this pull request
Nov 25, 2023
Add spellchecking script and make target for english docs --------- Co-authored-by: Ryan Rotter <rrotter@users.noreply.github.com> Co-authored-by: Karl Grasegger <gruenesgnu@posteo.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuing the work on #425
I made the script posix compliant, dropped the bash dependency and let implemented the shellcheck suggestions, thus all the problems @klardotsh talked about in the original PR should be taken care of.
I also updated the markdown search to exclude Japanese docs and made it work with the new docs structure.