Ignore 100 in no_magic_numbers rule (realm#5215)

KS1019 · Oct 2, 2023 · 17d17e8 · 17d17e8
1 parent 62391a7
commit 17d17e8
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 2 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -81,6 +81,11 @@
   [Martin Redington](https://github.com/mildm8nnered)
   [#5204](https://github.com/realm/SwiftLint/issues/5204)
 
+* 100 is no longer considered to be a magic number by the `no_magic_numbers`
+  rule.  
+  [Martin Redington](https://github.com/mildm8nnered)
+  [#5215](https://github.com/realm/SwiftLint/issues/5215)
+
 #### Bug Fixes
 
 * Respect grapheme clusters in counting the number of characters in the `collection_alignment` rule.  

diff --git a/Source/SwiftLintBuiltInRules/Rules/Idiomatic/NoMagicNumbersRule.swift b/Source/SwiftLintBuiltInRules/Rules/Idiomatic/NoMagicNumbersRule.swift
@@ -72,7 +72,8 @@ struct NoMagicNumbersRule: SwiftSyntaxRule, OptInRule, ConfigurationProviderRule
             Example("let foo = 1 << 2"),
             Example("let foo = 1 >> 2"),
             Example("let foo = 2 >> 2"),
-            Example("let foo = 2 << 2")
+            Example("let foo = 2 << 2"),
+            Example("let a = b / 100.0")
         ],
         triggeringExamples: [
             Example("foo(↓321)"),
@@ -167,7 +168,7 @@ private extension TokenSyntax {
         guard let number = Double(text.replacingOccurrences(of: "_", with: "")) else {
             return false
         }
-        if [0, 1].contains(number) {
+        if [0, 1, 100].contains(number) {
             return false
         }
         guard let grandparent = parent?.parent else {