Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default install stanza #127

Closed
pjf opened this issue Oct 21, 2014 · 2 comments · Fixed by #132
Closed

Default install stanza #127

pjf opened this issue Oct 21, 2014 · 2 comments · Fixed by #132
Assignees
Labels
Core (ckan.dll) Issues affecting the core part of CKAN Enhancement New features or functionality

Comments

@pjf
Copy link
Member

pjf commented Oct 21, 2014

While thinking about #112, it struck me that we could make a default install process which looks like this:

  • Search for the top-most directory with the same name as the mod identifier
  • Copy that directory into GameData
  • But not .ckan files
  • And also not Thumbs.db files (if we decide we don't like them)

This could trigger for a standard (not virtual) package that's completely missing an install stanza. It would cover the vast majority of simple mods, and would also avoid mistakes like I made with DogeCoinFlag where I can't spot the route to my own directories.

Topmost directory means we handle things like GameData/MyMod/assets/MyMod/foo.png correctly.

@pjf pjf added ★★☆ Enhancement New features or functionality Core (ckan.dll) Issues affecting the core part of CKAN labels Oct 21, 2014
@pjf pjf added ★★★ and removed ★★☆ labels Oct 22, 2014
@pjf
Copy link
Member Author

pjf commented Oct 22, 2014

Working on this now, because it's going to make everyone's lives much, much easier.

pjf added a commit to pjf/CKAN that referenced this issue Oct 22, 2014
@pjf pjf added In progress We're still working on this and removed ★★★ labels Oct 22, 2014
@pjf pjf self-assigned this Oct 22, 2014
pjf added a commit to pjf/CKAN that referenced this issue Oct 22, 2014
Seriously folks, write more tests, they're awesome.
pjf added a commit to pjf/CKAN that referenced this issue Oct 22, 2014
@pjf pjf added ready and removed In progress We're still working on this labels Oct 22, 2014
@pjf
Copy link
Member Author

pjf commented Oct 22, 2014

This also fixes a bug where we crash the GUI if we try to view
a module that has no install stanza. :)

(Although we'll need to address that separately for virtual packages,
as they'll never supply files by themselves.)

RichardLake pushed a commit to RichardLake/CKAN that referenced this issue May 30, 2015
RichardLake pushed a commit to RichardLake/CKAN that referenced this issue May 30, 2015
Seriously folks, write more tests, they're awesome.
RichardLake pushed a commit to RichardLake/CKAN that referenced this issue May 30, 2015
RichardLake added a commit to RichardLake/CKAN that referenced this issue May 30, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Core (ckan.dll) Issues affecting the core part of CKAN Enhancement New features or functionality
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants