Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use checkout action for notify workflow #4089

Merged
merged 3 commits into from
May 19, 2024
Merged

Use checkout action for notify workflow #4089

merged 3 commits into from
May 19, 2024

Conversation

HebaruSan
Copy link
Member

@HebaruSan HebaruSan commented May 19, 2024 •
edited
Loading

Motivation

#4088 seems to work, but a git clone command line is not the best level of abstraction for a workflow.

Changes

  • Now we use actions/checkout instead.
  • Now the merge script is updated to prevent merging if any of the checks fail or are still pending.
  • Now the notify jobs in release.yml and deploy.yml depend on their respective build/test jobs to ensure that any failures will be available in needs.*.result.

@HebaruSan HebaruSan added Build Issues affecting the build system Infrastructure Issues affecting everything around CKAN (the GitHub repos, build process, CI, ...) labels May 19, 2024
@HebaruSan HebaruSan force-pushed the refactor/notify-checkout branch from a09bc2d to 7607edd Compare May 19, 2024 01:05
@HebaruSan HebaruSan force-pushed the refactor/notify-checkout branch from 6975e5d to daf5475 Compare May 19, 2024 02:11
@HebaruSan
Copy link
Member Author

Classic!

$ .venv/bin/python bin/ckan_merge_pr.py --self-review 4089
Request GET /repos/KSP-CKAN/CKAN failed with 403: rate limit exceeded
Setting next backoff to 1012.615892s

@HebaruSan HebaruSan merged commit 0a3adcc into master May 19, 2024
6 checks passed
@HebaruSan HebaruSan deleted the refactor/notify-checkout branch May 19, 2024 02:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Build Issues affecting the build system Infrastructure Issues affecting everything around CKAN (the GitHub repos, build process, CI, ...)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@HebaruSan