Merge pull request #336 from HebaruSan/feature/auto-spec-version

Leave spec version out of generated netkans
KSP-CKAN · Aug 11, 2024 · 27959e8 · 27959e8
2 parents 99896de + e0a3528
commit 27959e8
Show file tree

Hide file tree

Showing 3 changed files with 1 addition and 4 deletions.
diff --git a/.github/workflows/coverage-report.yml b/.github/workflows/coverage-report.yml
@@ -15,7 +15,7 @@ permissions:
 jobs:
   coverage-report:
     runs-on: ubuntu-latest
-    if: ${{ github.event.workflow_run.conclusion == 'success' }}
+    if: ${{ false && github.event.workflow_run.conclusion == 'success' }}
     steps:
       - uses: actions/download-artifact@v4
         with:

diff --git a/netkan/netkan/cli/utilities.py b/netkan/netkan/cli/utilities.py
@@ -79,7 +79,6 @@ def analyze_mod(common: SharedArgs, ident: str, download_url: str) -> None:
     yaml.dump(ModAnalyzer(ident, download_url, common.game(common.game_id or 'KSP'))
                   .get_netkan_properties(),
               sio)
-    click.echo('spec_version: v1.18')
     click.echo(f'identifier: {ident}')
     click.echo(sio.getvalue())
 

diff --git a/netkan/netkan/spacedock_adder.py b/netkan/netkan/spacedock_adder.py
@@ -139,7 +139,6 @@ def make_spacedock_netkan(self, ident: str, info: Dict[str, Any]) -> Dict[str, A
                           self.__class__.__name__, ident, url, exc_info=exc)
         vref_props = {'$vref': props.pop('$vref')} if '$vref' in props else {}
         return {
-            'spec_version': 'v1.34',
             'identifier': ident,
             '$kref': f"#/ckan/spacedock/{info.get('id', '')}",
             **(vref_props),
@@ -191,7 +190,6 @@ def make_github_netkan(self, ident: str, gh_repo: Repository, info: Dict[str, An
                           self.__class__.__name__, ident, url, exc_info=exc)
         vref_props = {'$vref': props.pop('$vref')} if '$vref' in props else {}
         netkan = {
-            'spec_version': 'v1.34',
             'identifier': ident,
             '$kref': f"#/ckan/github/{gh_repo.full_name}",
             **(vref_props),