Handle weird version strings in download counter for archive.org #340
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The download counter throws this now:
Cause
When the mirrorer uploads that mod, the space in the version string is replaced with an underscore to conform to archive.org's rules about identifier formatting (see #307 and #328). But when the download counter looks for it, it's not.
Changes
mirror_item
is migrated fromCkanMirror
toCkan
along with its dependenciesmirror_item
in the download counter to ensure consistent item ids