-
Notifications
You must be signed in to change notification settings - Fork 215
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Earth Station Program Additions #2204
Conversation
Great start!! Quick hits since busy day.
The new RP0CollectScience parameter will be super useful throughout, I'm sure! |
Still WIP. Some descriptions are made, but some are still missing.
Added some more experiments. Very WIP though, as descriptions/completion messages are missing, alongside several placeholder values. In total there are 9 experiments for stationPrototypes and 13 experiments for earlySpaceStations. Still thinking about how to handle progressive EC requirements in contracts. Thinking between creating some generic "add-on" experiments and/or modifying the experiments with placeholder values for Early Space Station contracts. For the Improved Space Station contract, there isn't a real need for progressive EC requirements imo, but the EC requirement probably should be increased. |
I think a 1-2 year experiment for an improved station is probably too long. Skylab only had 3 crews for about 6 months total, and while Salyut stations were used longer, they still weren't continuously manned. So maybe something like a 6 or 9 month experiment for improved stations, and move anything over a year to modular/modern/advanced stations or whatever we want to call it for Mir/ISS analogs. I don't know that the contracts necessarily need progressive EC requirements if the experiments to be completed already need a certain amount. So for example if you have 13 experiments available for early Space Stations, say each contract/crew rotation requires completing at least 3 (just pulling out a number for discussion sake), then you already have a minimum EC requirement for the station based on the available experiments. |
Talked with NK about this in the discord actually. He seems to be fine with it since Salyuts 6 and 7 each were crewed for ~2 years (according to wikipedia)
Progressive EC requirements is smth NK wants for the Early Space Station contracts to provide some flexibility in design (e.g launching multiple stations or just launching one). I am currently doing this with the Long Dur. Space Hab. experiments but am still thinking of whether i want to modify historical experiments with (currently) unknown power consumption to add progression, or just add generic add-on experiments for this purpose. |
Progressive EC requirements I think ought to be handled by experiments (or life support or whatever) rather than anything explicit, yeah. I don't think that much progression is needed, but since we're presumably modeling everything from planned early-60s experiments through MOL through early Salyut and Skylab to late Salyut, there's presumably going to be huge variation in power available, and thus power consumed (since no scientist or engineer ever said "that's too much power available, I'm not going to use it" :D ). As I understand it, since the completion requirement for the experiments that track duration are just experiment-completion, there's no continuous-occupation requirement per station, just that there needs to be that much cumulative flight time. And per discord (but echoing here) I think it's fine for us to conceptualize things as "the US completed the Crewed Lunar program but only partially did early stations, and the Soviets completed Early Stations but only partially completed Crewed Lunar) -- counting the almost-manned Zond program, and N1/L3 design and prototyping, as a similar partial-completion. (As you can see from discord I too started from "that's too long, what about Skylab" but was convinced by Data :D ) |
I did some more reading as well after those messages and it makes a little more sense now to include longer programs. I do like the idea of having some experiments that can just be started and left for cumulative flight time, and some that require crew. |
I used the original stations program as a learning opportunity to figure out the programs/contracts mechanics and was finally able to get the contracts working correctly. Going to try adding in some of these experiments and the research payload to see if I can help narrow down some workable values for them. |
Renamed Improved Space Station to Second Generation Space Station Removed `completeInSequence = true` in orbit parameters since it is not necessary for completing science Update Programs.cfg to require only First Space Station and Second Gen. Subject to change. Replaced "@"with "@/" in Early Station so that the contract can function.
Made a commit so that the PR can be tested in game. Feel free to download the changes. Would recommend downloading some mods with station parts like FASA (only need the Gemini2 parts folder), SSPXR, and RN's Salyut & Skylab to get a better feeling for the experiments, since the express install only comes with station parts from SXT. |
Some things I've come across as I've played around with the files. I'm mostly using just the base Express Install for now just to see how it works with the stock install parts. -Definitely need to tweak the EC requirements. For example, a single ISS solar panel, at 1.0 scale and tech 6, produces around 15kW of power, or 15 EC/s. Long Duration Space Habitation 2 requires 2,000 EC/s, or basically a nuclear reactor, so off by at least an order of magnitude on the Early Station power requirements. Long Duration 1 is at 100, was it supposed to be 200 for LD2? Maybe change it to 2,000/min, which would still be 33 EC/s, but seems a little more reasonable. -Can't figure out where the difference is, but Long Duration 1 shows up blank in the science archive while all of the other experiments display correctly -There is a ScienceLabs.cfg file in the main RP-1 science folder that pertains to the mobile processing lab and a couple of others. With it and the Station Experiments config both enabled, the lab gets 2 Configure Crew Science buttons on the configuration screen, one for the original experiments and one for the new station ones. Disabling this file fixes it, not sure if there is any impact on other parts considered a lab? -Neither Skylab particularly like the new experiments at all. Tested the Express Install SXT one, and went ahead and installed the RN Skylab, both show the same thing, the Configure Crew Science button is gone and all of the new experiments are listed fully instead of the allotted number of slots. Tried to narrow this one down but it's beyond my feeble searching/coding abilities at this point. |
Mentioned on discord but I mixed up units and thought 1 EC/s = 1W, not 1kW. Will definitely be made more reasonable.
Huh. I'll have to look into that, I'm not sure why that's the case.
Considering that labs have little use in RP-1, I think it should be fine to remove the part that adds those experiments to parts with labs.
My understanding is that if the number of open slots available exceeds the number of experiments, all experiments are added and can't be configured. There may be other issues though, and I'll have to look into it Testing it in KSP, I also noticed that on my end the experiments for prototype and dev stations don't show up on the GUI when configured. Also noticed that the configure experiments GUI doesn't list the description, power requirements, or other elements while experiments for the crew capsules do show up. Did you notice any of this? |
I did, and that's actually what led me to looking in the Science Archive and noticing LDSH1 not showing up and got distracted by that instead. Forgot to mention it. I kind of went down a few rabbit holes when I was poking around in different files. Agreed on the lab part, though it does make me wonder if using the lab function may fix the Skylabs. I'll play around with that some more. |
Second Gen wasn't a config file for some reason. Fixed typo w/ LDSH experiments Remove duplicate experiments in Labs
All of the MOL/Early Salyut experiments have been fixed. They should now function in-game. I have not adjusted the values though. I'll do that at a later time. Another change is that those early experiments apply to both stations in the |
Doesn't seem like a huge deal since the prototype stations are so much more limited, kind of takes care of itself with built-in controls for what can be accomplished. |
Stations are heavily underdeveloped in RP-1 right now. Here's some additions that I've come up with.
What is added in this PR as of 8/28/23
spaceStationPrototypes
,spaceStationDev
,earlySpaceStations
)TO DO: