Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow only EC to be added inside procedural avionics. #2236

Merged
merged 1 commit into from
Sep 24, 2023

Conversation

siimav
Copy link
Contributor

@siimav siimav commented Sep 18, 2023

  • Avionics tooling is just tonnage and tank size. There is no additional SM or battery tooling any longer. Previously you were forced to tool some SM diameter along with avionics. This means that upgrading from one battery level to another doesn't require any tooling either.
  • No spherical tank volume hacks and no 50% penalty for calculating usable volume inside the avionics part.
  • Battery tank definitions are just copies of SM I to SM IV but can have no resources other than EC.
  • Battery levels are upgraded with electronics blue sky nodes instead of mat sci

Things to consider / figure out:

  • Do we want more battery levels? Current progression ends with Apollo. Although by the looks of it SM-IV is already in the ballpark of modern Li-Ion batteries.
  • We have EC/kg progression but nothing for EC/l. 1 liter of volume always contains 1000EC. Do we want that? How should it be implemented (utilization limits, RF internal tank density)?
  • SM tanks can have EC too and I doubt we want to remove that option. So if we want more battery levels then there's a mismatch between EC stored in SM tanks and EC stored in avionics.

Depends on KSP-RO/RealismOverhaul#2915

This allows the removal of spherical tank shenanigans and the need to tool separate SM tanks along with the avioncs unit.
@github-actions
Copy link

Download the artifacts for this pull request:

@NathanKell
Copy link
Member

Closes #2226

@NathanKell NathanKell merged commit 2b72bcd into master Sep 24, 2023
3 checks passed
@NathanKell NathanKell deleted the SimplerAvionics branch September 24, 2023 01:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants