Make sunlight brightness vary with distance from the Sun #194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Liriodendr0n
changed the title
|
This seems to affect atmosphere-less bodies much more strongly than bodies with scatterer atmospheres, and makes very bright white moons like Enceladus and Europa look sort of strange. |
|
Are you still working on this PR? |
siimav
reviewed
Feb 24, 2021
|
|
||
| IVASunColor = 1.0, 1.0, 1.0, 1.0 | ||
|
|
||
| ambientLightColor = 1.0, 1.0, 1.0, 1.0 |
There was a problem hiding this comment.
Should be 0.06, 0.06, 0.06, 1.0, otherwise there's way too much ambient light
|
Interestingly my ingame results do not match at all with the images in your gallery. Everything appears to be a fair bit darker on my install. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated Sunlight and Saturn-Ring brightness