Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Turn off finalizeOrbit in Kopernicus configs #285

Merged
merged 1 commit into from
May 29, 2023

Conversation

lamont-granquist
Copy link

This causes problems due to the way that the KSP Orbit class is written and the way that Kopernicus attempts to scribble over the meanMotion is not internally consistent. That would need to be patched and debugged in stock fairly extensively.

The intended behavior also makes it difficult to simulate the Keplerian motion of planets/satellites in RSS since the referenceBody.gravParameter is incorrect and needs to be fixed by "reverse engineering" the effective mu from the meanMotion on the celestial. This adds a lot of headache.

Even apart from those issues, the buginess remains and causes issues with Keplerian motion, and creates issues that have been seen with detecting SOI encounters in the Earth-Moon system. Attempting to fix those issues by patching KSP for the meanMotion problems was not successful either, which suggests some of the other tweaking that finalizeOrbit is doing may be buggy as well.

KSPModdingLibs/KSPCommunityFixes#141 Kopernicus/Kopernicus#584

Merging this may not be the right way to fix this though since when I tried disabling this value on a save, the Moon jumped by about 90 degrees in its orbit and a ManeuverNode which was on an encounter was now no longer close.

This change may be save-breaking.

This causes problems due to the way that the KSP Orbit class is written
and the way that Kopernicus attempts to scribble over the meanMotion is
not internally consistent.  That would need to be patched and debugged
in stock fairly extensively.

The intended behavior also makes it difficult to simulate the Keplerian
motion of planets/satellites in RSS since the referenceBody.gravParameter
is incorrect and needs to be fixed by "reverse engineering" the effective
mu from the meanMotion on the celestial.  This adds a lot of headache.

Even apart from those issues, the buginess remains and causes issues
with Keplerian motion, and creates issues that have been seen with
detecting SOI encounters in the Earth-Moon system.  Attempting to fix
those issues by patching KSP for the meanMotion problems was not
successful either, which suggests some of the other tweaking that
finalizeOrbit is doing may be buggy as well.

KSPModdingLibs/KSPCommunityFixes#141
Kopernicus/Kopernicus#584

Merging this may not be the right way to fix this though since when I
tried disabling this value on a save, the Moon jumped by about 90
degrees in its orbit and a ManeuverNode which was on an encounter was
now no longer close.

This change may be save-breaking.
@lamont-granquist
Copy link
Author

Probably is save breaking. I encourage people to think about how to do this other than just hit merge, but this is a PR-as-an-issue more or less to track the fact that this needs to get done somehow, because the existing behavior is totally broken.

@NathanKell NathanKell merged commit e6b87b6 into KSP-RO:master May 29, 2023
@siimav siimav mentioned this pull request Jun 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants