You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
ModuleDecouple on engine plates is setting all attached parts as "shielded from airstream", excepted the part attached to the node defined in the bottomNodeName of the ModuleJettison module.
The intent is to disable drag (as well as some interactions like deploying animated parts) on all other node-attached parts, but "all other node-attached parts" will also typically include the part attached to the engine plate top node, which is clearly an unwanted oversight.
Fundamentally, ModuleDecouple is missing a way to define exclusions or inclusions for airstream-shielded nodes in its config. Implementing such a config option is difficult and would require concrete patches for every stock and modded part using isEnginePlate = true.
Alternatively, we can use some heuristics to determine which nodes should be excluded. For all stock engine plates, excluding nodes with id = "top" would work, but there is no guarantee this would hold true with modded parts.
Another heuristic would be to exclude all nodes whose orientation is significantly different than the node identified by the bottomNodeName of the ModuleJettison module. This might fail in case of a complex modded part setup, but as of writing a quick github search show no potential issue.
The text was updated successfully, but these errors were encountered:
- New KSP bugfix : [EnginePlateAirstreamShieldedTopPart](#52) (Thanks to @yalov (flart) for reporting and to @Aelfhe1m for coming up with a clever solution).
- New KSP bugfix : [AsteroidInfiniteMining](#51) (Thanks to @Rodg88 for reporting).
- New KSP bugfix : [EnginePlateAirstreamShieldedTopPart](#52) (Thanks to @yalov (flart) for reporting and to @Aelfhe1m for coming up with a clever solution).
- New KSP bugfix : [AsteroidInfiniteMining](#51) (Thanks to @Rodg88 for reporting).
ModuleDecouple
on engine plates is setting all attached parts as "shielded from airstream", excepted the part attached to the node defined in thebottomNodeName
of theModuleJettison
module.The intent is to disable drag (as well as some interactions like deploying animated parts) on all other node-attached parts, but "all other node-attached parts" will also typically include the part attached to the engine plate top node, which is clearly an unwanted oversight.
Fundamentally,
ModuleDecouple
is missing a way to define exclusions or inclusions for airstream-shielded nodes in its config. Implementing such a config option is difficult and would require concrete patches for every stock and modded part usingisEnginePlate = true
.Alternatively, we can use some heuristics to determine which nodes should be excluded. For all stock engine plates, excluding nodes with
id = "top"
would work, but there is no guarantee this would hold true with modded parts.Another heuristic would be to exclude all nodes whose orientation is significantly different than the node identified by the
bottomNodeName
of theModuleJettison
module. This might fail in case of a complex modded part setup, but as of writing a quick github search show no potential issue.The text was updated successfully, but these errors were encountered: