-
Notifications
You must be signed in to change notification settings - Fork 415
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Submission: Pijul (tutorial) #1356
Conversation
pre-review submission!
@khaes-kth I think you were the assigned TA to this task. The github URL is https://github.com/ysndr/katacoda-scenarios |
Hi @ysndr , Fine, I'll try to give you some feedback until tomorrow. |
Hi @ysndr Thank you for the tutorial. Very useful and interesting. Here are my comments; Very good introduction. The figures look too large on my computer, I do not know if you can fix them. Step 1:
Typo. Step 2:You say:
Does this mean Step 3:
Interesting. What are dependencies? That's the trickiy part I guess. After continuing the tutorial, I realized you have discussed dependencies. The first time you mention
The sentence can be improved.
Typo. It is better to tell the reader to choose a specific commit hash when running commands that require a HASH. What happened to me was that I revoked the first ciao commit and when I changed the same file and recoreded it I could not see the dependencies because the first commit was revoked. Step 4:
As far as I remember, you did not ask the reader to create an account before. Please explain where I should create an account. You can just mention the registration process in 1-2 sentences (e.g., go to ... and register with your email and ....). Step 5:
I can guess what you mean, but it makes sense for you to make this sentence a bit more clear with explaining
Typo.
It is better to tell the reader what to do when the editor is opened after running this command. Step 6:
Typo. It is good to make the goal of the game clear. What should I expect to happen when I am done with the task? |
@khaes-kth thank you for the valuable feedback |
@khaes-kth the feedback was taken care of 4 days ago, shouldn't this PR be merged? |
Submission of the tutorial on pijul.
Follows #1189
Awaiting review to be incorporated before the deadline.
Self-assessment based on grading guidelines: