Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix installation of Abimo #12

Open
MRigal opened this issue Sep 12, 2022 · 1 comment
Open

Fix installation of Abimo #12

MRigal opened this issue Sep 12, 2022 · 1 comment

Comments

@MRigal
Copy link

MRigal commented Sep 12, 2022

If Abimo was not installed before, there is no chance that it succeeds currently.

Easy fix for Windows:
The script checks for version 3.3.0, but then installs 3.2.2, see https://github.com/KWB-R/kwb.abimo/blob/master/R/install_abimo.R#L22
I would advise to use a "global-ish" variable to store the "recommended" version to avoid these problem in the future.

Also, it enforces a "win64" platform, which is problematic to be ran on a server (Linux) or a Mac OS software. See https://github.com/KWB-R/kwb.abimo/blob/master/R/install_abimo.R#L16
Ideally, the original packages Abimo should be available for all main platforms.

In the meantime, the R package should identify the operating system using something like https://stat.ethz.ch/R-manual/R-devel/library/base/html/Sys.info.html and for non-windows platform warn that it cannot be installed automatically but hint that the software should be built from source and then linked with the fitting suffix in the R-site-library folder.

@hsonne
Copy link
Member

hsonne commented Sep 15, 2022

Regarding the version number mismatch now, since #14, the version number is returned by a function.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants