Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow usage of non-Windows path #13

Closed
MRigal opened this issue Sep 12, 2022 · 2 comments
Closed

Allow usage of non-Windows path #13

MRigal opened this issue Sep 12, 2022 · 2 comments

Comments

@MRigal
Copy link

MRigal commented Sep 12, 2022

UNIX (Linux and Mac OS) paths is using "/" as separator, unlike Windows which uses "\"

Unfortunately, the R package is using a "fullWinPath" function which does not handle other platform than window. For example, see https://github.com/KWB-R/kwb.abimo/blob/master/R/run_abimo.R#L53

This way, a path input_file <- '/Users/matthieu/dev/kwb.abimo/data/abimo_input_2019.rda' becomes Usersmatthieudevkwb.abimodataabimo_input_2019.rda and it fails...

@MRigal
Copy link
Author

MRigal commented Sep 12, 2022

FYI, to belong to this point nevertheless the issues pointed in #12, I had to do build the Qt/C++ app locally and faked it as the Windows executable by creating a symlink:
sudo ln -s /Users/matthieu/dev/abimo/src/app/app.app/Contents/MacOS/app /opt/homebrew/lib/R/4.2/site-library/kwb.abimo/extdata/abimo_v3.3.0_win64/Abimo.exe

MRigal pushed a commit to technologiestiftung/kwb.abimo that referenced this issue Sep 12, 2022
@hsonne
Copy link
Member

hsonne commented Sep 15, 2022

With #14 slashes in paths are only converted to backslashes on Windows computers.

@hsonne hsonne closed this as completed Sep 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants