Clean #9
Open
Clean #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- reindent
- add space after "if"
- use else if (...) instead of else {if (...)}
- no need for paste0() within message()
- reindent - use helper variable "satellite_columns" - use all(..) instead of sum(...) == 2 - use if () expr. directly in unnest() call
- use pipe operator (more often) - loop through list elements x instead of list indices idx, where possible - rename "idx" to "i" - use helper variable "geometries"
mrustl
reviewed
May 22, 2024
|
|
||
| collectionList <- collection$toList(nImages) | ||
|
|
||
| metadata_list <- collection$fromImages(collectionList) | ||
| metadata_list <- metadata_list$getInfo() |
There was a problem hiding this comment.
metadata_list$getInfo()$features da metadata_list <- metadata_list$getInfo() gelöscht wurde
There was a problem hiding this comment.
Hm. Steht das nicht in Zeile 33?
Merge branch 'dev' into clean # Conflicts: # R/flatten_results.R
- improve names (current_date -> today) - check year input, call as.integer(year) once
- use intermediate variable "n_lakes" - use &&, || instead of &, |, within if () - be positive and gramatically correct: "success" instead of "not_failed"
- use intermediate variable "n_lakes" - use &&, || instead of &, |, within if () - be positive and gramatically correct: "success" instead of "not_failed"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.