Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: check Python package "pyswmm" #1

Open
mrustl opened this issue Mar 18, 2021 · 1 comment
Open

feat: check Python package "pyswmm" #1

mrustl opened this issue Mar 18, 2021 · 1 comment
Assignees
Labels
enhancement New feature or request

Comments

@mrustl
Copy link
Member

mrustl commented Mar 18, 2021

More people contribute to pyswmm compared to swmmr, which we currently use in different projects.

However, pyswmm could be also accessed from R via the reticulate R package.

Using pyswmm would improve the readability of the code e.g. for LID definition which is cumbersome with swmmr (e.g. LID parameters defined by their column position instead of their names: https://github.com/KWB-R/LIDsensitivity/blob/master/sensitivityAnalysis.R#L85):
https://pyswmm.readthedocs.io/en/latest/tutorial/tutorial.html#lid-controls

@mrustl mrustl added the enhancement New feature or request label Mar 18, 2021
@mrustl mrustl self-assigned this Mar 18, 2021
@mrustl
Copy link
Member Author

mrustl commented Mar 26, 2021

DLL load Error occing in case of importing pyswmm is shown here:

https://github.com/KWB-R/kwb.swmm/blob/93441fcfebb297459fce7f3cd527a2b94af3a553/vignettes/swmm_python.Rmd

Is probably related to problems in R package reticulate to deal with different Cindy environments/Python Versions:
rstudio/reticulate#367

mrustl added a commit that referenced this issue Apr 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant