fix: change ordering of events when submitting a bundle #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnletey
added
backport/v1.1.x
troykessler
previously approved these changes
May 8, 2023
johnletey
changed the title
troykessler
approved these changes
May 8, 2023
mergify bot
pushed a commit
that referenced
this pull request
May 8, 2023
Co-authored-by: John Letey <john@kyve.network> (cherry picked from commit 4800744)
mergify bot
pushed a commit
that referenced
this pull request
May 8, 2023
Co-authored-by: John Letey <john@kyve.network> (cherry picked from commit 4800744) # Conflicts: # CHANGELOG.md
This was referenced May 8, 2023
johnletey
pushed a commit
that referenced
this pull request
May 8, 2023
#43) Co-authored-by: Maximilian Breithecker <72022235+mbreithecker@users.noreply.github.com>
johnletey
added a commit
that referenced
this pull request
May 8, 2023
#44) Co-authored-by: Maximilian Breithecker <72022235+mbreithecker@users.noreply.github.com> Co-authored-by: John Letey <john@kyve.network>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a bundle is uploaded the uploader automatically votes valid on the uploaded bundle without the need to submit an extra transaction (or message). However, in this case the VoteEvent got emitted before the BundleProposed event. This PR swaps the event emission.