Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: improve validation of pool proposals #74

Merged
merged 3 commits into from
Jun 14, 2023
Merged

Conversation

troykessler
Copy link
Member

No description provided.

@troykessler troykessler self-assigned this May 31, 2023
@troykessler troykessler marked this pull request as ready for review June 5, 2023 09:36
@troykessler troykessler requested a review from mbreithecker as a code owner June 5, 2023 09:36
johnletey
johnletey previously approved these changes Jun 6, 2023
Copy link
Member

@johnletey johnletey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great -- should we add something to the CHANGELOG?

@johnletey johnletey added this to the v1.3 milestone Jun 6, 2023
@johnletey johnletey added the backport/v1.3.x backport patches to v1.3.x branch label Jun 6, 2023
@johnletey johnletey changed the title added correct validations for create and update pool chore: improve validation of pool proposals Jun 6, 2023
@johnletey johnletey merged commit c465e29 into main Jun 14, 2023
@johnletey johnletey deleted the fix/zero-operating-cost branch June 14, 2023 13:22
mergify bot pushed a commit that referenced this pull request Jun 14, 2023
Co-authored-by: John Letey <john@kyve.network>
(cherry picked from commit c465e29)
johnletey pushed a commit that referenced this pull request Jun 14, 2023
Co-authored-by: Troy Kessler <43882936+troykessler@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport/v1.3.x backport patches to v1.3.x branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants