Fix going to custom start not stopping timer #442
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
walliski
reviewed
Jan 9, 2023
| @@ -37,6 +37,11 @@ bool GetHasVirtualEndButton(int client) | |||
| return hasVirtualEndButton[client]; | |||
| } | |||
|
|
|||
| bool GetVirtualStartCourse(int client) | |||
| { | |||
| return virtualStartCourse[client]; | |||
There was a problem hiding this comment.
This is an int, not a bool, right - so return type mismatches?
There was a problem hiding this comment.
whoops yeah. I'm not too fond of this PR though, because it kinda disables the behavior in #346 if there's a timer tech around, so consider this a temporary fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you
!sspand setup timer tech for a button course, then start a course using zones, then do!start, the timer for the zone course does not get stopped. Caused by #346.