-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move the source of truth of kaggle-api development to this repository #557
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I made lots of comments about line breaks. Those can be considered optional. I did clean up the language in a few places and those should be included.
Also, note that when you first see my comments you may have a bunch that are collapsed. I had to click the line that said there were 26 hidden comments to see them all. Edit: even then, there were still six collapsed under another |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
I would have assume that the delta between the repos to be a lot smaller. Has the repo not been synced for a while?
Also, is it possible to get ride of the formatting changes?
The diff in the kaggle/ directory are indeed mostly formatting changes, but unclear where they come from. |
Changes
hatch
, for examplehatch run compile
to generate the python files to release to pypiNext
Ideas for medium-term
Bug
http://b/325046928