Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

1.15.4: update to use Chessnut package #291

Merged
merged 4 commits into from
Oct 30, 2024
Merged

1.15.4: update to use Chessnut package #291

merged 4 commits into from
Oct 30, 2024

Conversation

bovard
Copy link
Member

@bovard bovard commented Oct 28, 2024

No description provided.

@bovard bovard requested a review from lipovetz October 28, 2024 23:07
lipovetz
lipovetz approved these changes Oct 29, 2024
View reviewed changes
Copy link
Member

@lipovetz lipovetz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

kaggle_environments/envs/chess/chess.py Outdated Show resolved Hide resolved
kaggle_environments/envs/chess/chess.py Outdated Show resolved Hide resolved
@lipovetz
Copy link
Member

[optional] I left out some style nits to avoid being pedantic, but consider running through pylint and doing some cleanup

@bovard bovard merged commit 00422e8 into master Oct 30, 2024
4 checks passed
@bovard bovard deleted the chess-nut branch October 30, 2024 22:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lipovetz lipovetz lipovetz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bovard @lipovetz