Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix reward in chess.json #324

Merged
merged 1 commit into from
Dec 11, 2024
Merged

Conversation

w9PcJLyb
Copy link
Contributor

Because, at this moment, I can't initialize chess environment with steps if the game's result was a draw.

>>> kaggle_environments.make("chess", steps=game["steps"])

raise InvalidArgument(
kaggle_environments.errors.InvalidArgument: Default state generation failed for #0: 0.5 is not one of [-1, 0, 1]

Failed validating 'enum' in schema['properties']['reward']:
    {'description': '-1 = Lost, 0 = Draw/Ongoing, 1 = Won',
     'type': ['number', 'null'],
     'default': 0,
     'enum': [-1, 0, 1]}

On instance['reward']:
    0.5

Copy link

google-cla bot commented Nov 26, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

Copy link
Member

@bovard bovard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@bovard bovard merged commit ecd9670 into Kaggle:master Dec 11, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants