fix: keyboard focus looping issue #158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Are there any tests that you can add that demonstrate the issue and that your solution resolves it? |
TSeelig
force-pushed
the
bugfix-keyboard-focus-loop-issue
branch
4 times, most recently
from
4dcb0f0 to
c5e19fa
Compare
TSeelig
force-pushed
the
bugfix-keyboard-focus-loop-issue
branch
from
c5e19fa to
ef606cb
Compare
lewisbirks
reviewed
Jan 26, 2024
lewisbirks
reviewed
Jan 29, 2024
lewisbirks
approved these changes
Jan 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolved an issue where changing focus with keyboard tabbing would focus on un expected element (date-picker__dialog).
Issue
When user expects to switch keyboard focus from close button to previous month button (forward tabbing) they first had to go through the unexpected focus on date-picker__dialog before focusing on previous month button.
When user expects to switch keyboard focus from previous month button to close button (backwards tabbing) they would tab first to date-picker__dialog unexpectedly but then would be unable to tab backwards from there to the close button as focus was essentially stuck on the date-picker__dialog until they switched focus with forward tabbing.
Resolution
Video demo
date-picker-bug-fixed.mov
date-picker-bug.mov
(at end of above bug demo I am pressing back tab multiple times but it does not go back to the cancel button)